ARROW-13820: [R] Rename na.min_count to min_count and na.rm to skip_nulls #11079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcook
reviewed
Sep 8, 2021
Co-authored-by: Ian Cook <ianmcook@gmail.com>
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
…ulls Also contains ARROW-13821: [R] Handle na.rm in sd, var bindings The only other place we take nonstandard C++ options in make_compute_options is for a few types (like count) where there is an enum that controls options and we switch off based on a boolean. We can try to clean that up but I'm inclined to wait to see if anyone needs lower-level control. Closes apache#11079 from nealrichardson/na-options Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also contains ARROW-13821: [R] Handle na.rm in sd, var bindings
The only other place we take nonstandard C++ options in make_compute_options is for a few types (like count) where there is an enum that controls options and we switch off based on a boolean. We can try to clean that up but I'm inclined to wait to see if anyone needs lower-level control.