ARROW-559: Add release verification script for Linux #1102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ida0d5a74765e28f8f88306edfef12f6bf723c859
Change-Id: I827922474a9180396079e1b377f52df683fc4696
Change-Id: I0d26139a7fdf7ebc62ff2937509209fec2e9d5d3
kou
approved these changes
Sep 15, 2017
| mkdir parquet-cpp/build | ||
| pushd parquet-cpp/build | ||
|
|
||
| cmake .. -DCMAKE_INSTALL_PREFIX=$PARQUET_HOME \ |
|
|
||
|
|
||
| test_glib() { | ||
| # Build and test GLib, requires newer GLib (I used 2.52.3), so install that |
Member
There was a problem hiding this comment.
GLib 2.44 or later is required. Because I used G_DECLARE_DERIVABLE_TYPE().
Member
There was a problem hiding this comment.
FYI: I used https://launchpad.net/~jonathonf/+archive/ubuntu/gtk3.18 to install newer GLib on Travis CI: https://github.com/apache/arrow/blob/master/ci/travis_before_script_c_glib.sh#L32-L34
I think that building GLib isn't bad.
Change-Id: Id7278ede0ebb0da91060ed769309bc4addd469e7
Change-Id: I81be820d1c345ba364c2e5fb9a4ed2f24f1f15a0
Member
Author
|
I'm going to change the Boost stuff to use shared libraries since using static libraries will cause problems for people using libraries from a Linux package manager |
Change-Id: Id840b188db8d6b9d96ef1feacb3918302574af7c
Member
|
This looks nice, I'm working on Darwin support |
xhochy
approved these changes
Sep 15, 2017
Member
xhochy
left a comment
There was a problem hiding this comment.
+1
I have some libpython linking problems on macOS in the tests, I need to take a deeper look into this before we can add macOS/Darwin support.
Member
Author
|
OK, no problem |
asfgit
pushed a commit
that referenced
this pull request
Sep 17, 2017
Since we're accumulating a bunch of components, I started this script which we can refine to make verifying releases easier for others. I bootstrapped some pieces off https://github.com/apache/parquet-cpp/blob/master/dev/release/verify-release-candidate, very helpful! This script: * Checks GPG signature, checksums * Installs temporary Python install for the duration of these tests * Builds/install C++ and runs tests (with Python and Plasma) * Builds parquet-cpp against the Arrow RC * Python (with Parquet and Plasma extensions) * C GLib (requires Ruby in PATH and the gems indicated in README) * Integration tests * JavaScript (requires NodeJS >= 6.0.0) There are some potentially snowflake-y aspects to my environment: * BOOST_ROOT is set to a Boost install location containing libraries built with `-fPIC`. I'm not sure what to do about this one. One maybe better option is to use system level boost and shared libraries * Maven 3.3.9 is in PATH * NodeJS 6.11.3 is in PATH There are probably some other things that Linux users will run into as they run this script. I had to compile GLib libraries in this since the ones at system level (Ubuntu 14.04) are too old. cc @kou @xhochy Author: Wes McKinney <wes.mckinney@twosigma.com> Closes #1102 from wesm/ARROW-559 and squashes the following commits: 8fd6530 [Wes McKinney] Use Boost shared libraries 3531927 [Wes McKinney] Add note to dev/README.md 079b5e4 [Wes McKinney] Fix comments 17f7ac0 [Wes McKinney] More fixes, finally works adb3146 [Wes McKinney] More work on release verification script 86ef171 [Wes McKinney] Start Linux release verification script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're accumulating a bunch of components, I started this script which we can refine to make verifying releases easier for others.
I bootstrapped some pieces off https://github.com/apache/parquet-cpp/blob/master/dev/release/verify-release-candidate, very helpful!
This script:
There are some potentially snowflake-y aspects to my environment:
-fPIC. I'm not sure what to do about this one. One maybe better option is to use system level boost and shared librariesThere are probably some other things that Linux users will run into as they run this script.
I had to compile GLib libraries in this since the ones at system level (Ubuntu 14.04) are too old.
cc @kou @xhochy