ARROW-13772: [R] Binding for median aggregation #11018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
ee8c6a2 to
c4db4f1
Compare
Member
|
This is blocked until #11159 merges. |
ianmcook
reviewed
Sep 17, 2021
9515eeb to
c44d54b
Compare
ianmcook
reviewed
Sep 21, 2021
Member
|
I will rebase this after #11204 merges. Until then, tests will fail. |
421abf6 to
a837785
Compare
Member
|
I addressed all comments and rebased after the |
ianmcook
added a commit
that referenced
this pull request
Sep 25, 2021
This is a trivially small fix to resolve a test failure on older versions of R following ARROW-13772 (#11018). Closes #11235 from ianmcook/ARROW-13772-fix Authored-by: Ian Cook <ianmcook@gmail.com> Signed-off-by: Ian Cook <ianmcook@gmail.com>
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
This adds a binding for `median()` in `dplyr::summarise()`. This also adds a binding for `quantile()` but only for a single probability per function call (`length(probs) == 1`). With both bindings, the results are approximate, calculated using the tdigest algorithm. The user is warned once per session that the results are approximate. Closes apache#11018 from thisisnic/ARROW-13772_median_hash Lead-authored-by: Ian Cook <ianmcook@gmail.com> Co-authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Ian Cook <ianmcook@gmail.com>
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
This is a trivially small fix to resolve a test failure on older versions of R following ARROW-13772 (apache#11018). Closes apache#11235 from ianmcook/ARROW-13772-fix Authored-by: Ian Cook <ianmcook@gmail.com> Signed-off-by: Ian Cook <ianmcook@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a binding for
median()indplyr::summarise(). This also adds a binding forquantile()but only for a single probability per function call (length(probs) == 1). With both bindings, the results are approximate, calculated using the tdigest algorithm. The user is warned once per session that the results are approximate.