-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[C++][Gandiva] default cache size is incorrect and too small #40040
Copy link
Copy link
Closed
Description
Describe the bug, including details regarding any error messages, version, and platform.
The default cache size of Gandiva is 500 by default, and this value was set for LLVM module based cache (which took larger memory size) and is too small for the current object code cache.
This part was changed several times, and the history is like this:
- https://issues.apache.org/jira/browse/ARROW-15514, Add flag to enable Gandiva Object Code
- [C++][Gandiva] Add flag to enable Gandiva Object Code #30987, the PR added a macro called
GANDIVA_ENABLE_OBJECT_CODE_CACHEto enable object code cache conditionally during build time
- https://issues.apache.org/jira/browse/ARROW-15648, Fix the size of the Gandiva cache
- ARROW-15648: [C++][Gandiva] Fix the size of the Gandiva cache #12394, this PR added a new default
DEFAULT_CACHE_SIZEwhose value is500000, and is only enabled when theGANDIVA_ENABLE_OBJECT_CODE_CACHEis enabled during build time
- https://issues.apache.org/jira/browse/ARROW-16055, Fix the performance hit in queries when enabling object code cache in gandiva
- ARROW-16055: [C++][Gandiva] Skip unnecessary work during cache hit when using object code cache #12742, this PR removed the
GANDIVA_ENABLE_OBJECT_CODE_CACHEflag and made object code cache as default. However, the default cache size's flag was not removed, which is unexpected
Component(s)
C++ - Gandiva
Reactions are currently unavailable