Skip to content

ARROW-16055: [C++][Gandiva] Skip unnecessary work during cache hit when using object code cache#12742

Closed
projjal wants to merge 1 commit intoapache:masterfrom
projjal:objectcache
Closed

ARROW-16055: [C++][Gandiva] Skip unnecessary work during cache hit when using object code cache#12742
projjal wants to merge 1 commit intoapache:masterfrom
projjal:objectcache

Conversation

@projjal
Copy link
Copy Markdown
Contributor

@projjal projjal commented Mar 29, 2022 •
edited
Loading

This change enables object code cache and skips the unnecessary work that was done before loading the compiled object code in memory. The following still needs to be done:

  • expression decomposition in order to create the function and in holders in memory
  • Add mappings for global functions to the llvm module

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2022

https://issues.apache.org/jira/browse/ARROW-16055

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2022

⚠️ Ticket has no components in JIRA, make sure you assign one.

@projjal projjal force-pushed the objectcache branch 2 times, most recently from e5b336a to 99a7ef7 Compare March 29, 2022 12:45
@projjal projjal closed this Mar 30, 2022
@projjal projjal reopened this Apr 7, 2022
@projjal projjal force-pushed the objectcache branch 3 times, most recently from 3e25613 to fd50245 Compare April 11, 2022 03:53
pravindra
pravindra reviewed Apr 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pravindra pravindra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pls add a more detailed comment (enabling object cache, setup function pointers after getting object code from cache) ?

@pravindra pravindra closed this in 0e3043d Apr 29, 2022
@ursabot
Copy link
Copy Markdown

ursabot commented May 5, 2022

Benchmark runs are scheduled for baseline = 564eb97 and contender = 0e3043d. 0e3043d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.45% ⬆️0.27%] test-mac-arm
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.43% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 0e3043d4 ec2-t3-xlarge-us-east-2
[Finished] 0e3043d4 test-mac-arm
[Finished] 0e3043d4 ursa-i9-9960x
[Finished] 0e3043d4 ursa-thinkcentre-m75q
[Finished] 564eb97a ec2-t3-xlarge-us-east-2
[Finished] 564eb97a test-mac-arm
[Finished] 564eb97a ursa-i9-9960x
[Finished] 564eb97a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link
Copy Markdown

ursabot commented May 5, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@niyue niyue mentioned this pull request Feb 12, 2024
Closed
@js8544 js8544 mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pravindra pravindra pravindra approved these changes

Assignees

No one assigned

Labels

Component: C++ Component: Gandiva

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@projjal @ursabot @pravindra