Skip to content

Conversation

@turbaszek
Copy link
Member

@turbaszek turbaszek commented Mar 25, 2020


Issue link: WILL BE INSERTED BY boring-cyborg
Depends on #7853

Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@turbaszek turbaszek requested a review from mik-laj March 25, 2020 13:10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about more explicit name like GoogleSheetsHook.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can refactor it, the hook already exists

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it in next PR

Copy link
Contributor

@michalslowikowski00 michalslowikowski00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

@turbaszek turbaszek force-pushed the add-gcs-sheets-operators branch 2 times, most recently from 021192e to b840655 Compare March 25, 2020 18:50
@turbaszek turbaszek marked this pull request as ready for review March 25, 2020 18:51
@turbaszek turbaszek requested a review from potiuk March 25, 2020 18:51
@turbaszek turbaszek added area:providers provider:google Google (including GCP) related issues labels Mar 25, 2020
@turbaszek turbaszek force-pushed the add-gcs-sheets-operators branch from 6905420 to fdf2d20 Compare March 27, 2020 09:49
@michalslowikowski00
Copy link
Contributor

🚀

@potiuk
Copy link
Member

potiuk commented Mar 27, 2020

Go!

@turbaszek turbaszek merged commit 01f9942 into apache:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants