Change signature of GSheetsHook methods #7853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik-laj
reviewed
Mar 24, 2020
Member
There was a problem hiding this comment.
Has this Hook been released in any version of Airflow? If so, then we should maintain backward compatibility. You can do it with a decorator. We have the similar decorator in the codebase: https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/hooks/dataflow.py#L52-L81
Member
Author
There was a problem hiding this comment.
I don't see this hook here:
https://github.com/apache/airflow/tree/v1-10-stable/airflow/contrib/hooks
mik-laj
approved these changes
Mar 25, 2020
8713157 to
be3272f
Compare
5 tasks
kaxil
approved these changes
Mar 25, 2020
potiuk
approved these changes
Mar 25, 2020
be3272f to
60bc9bd
Compare
Member
Author
|
Force pushed to start Travis job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.