Skip to content

[AIRFLOW-6977] Fix BigQuery DTS example DAG #7612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Mar 4, 2020
Merged

[AIRFLOW-6977] Fix BigQuery DTS example DAG #7612

potiuk merged 1 commit into from
Mar 4, 2020

Conversation

@turbaszek
Copy link
Member

@turbaszek turbaszek commented Mar 3, 2020 •
edited by boring-cyborg bot
Loading

Issue link: AIRFLOW-6977

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Mar 3, 2020
@turbaszek turbaszek requested a review from mik-laj March 3, 2020 13:37
@codecov-io
Copy link

codecov-io commented Mar 4, 2020

Codecov Report

Merging #7612 into master will decrease coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7612      +/-   ##
=========================================
- Coverage   86.73%   86.3%   -0.43%     
=========================================
  Files         897     897              
  Lines       42747   43177     +430     
=========================================
+ Hits        37075   37266     +191     
- Misses       5672    5911     +239
Impacted Files Coverage Δ
.../google/cloud/example_dags/example_bigquery_dts.py 100% <100%> (ø) ⬆️
...flow/providers/apache/cassandra/hooks/cassandra.py 21.51% <0%> (-72.16%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/providers/redis/operators/redis_publish.py 50% <0%> (-50%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/providers/mongo/sensors/mongo.py 53.33% <0%> (-46.67%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0%> (-45.08%) ⬇️
airflow/providers/redis/sensors/redis_key.py 61.53% <0%> (-38.47%) ⬇️
airflow/executors/celery_executor.py 50.67% <0%> (-37.84%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 69.69% <0%> (-25.26%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3cddd...66d3872. Read the comment docs.

@michalslowikowski00
Copy link
Contributor

michalslowikowski00 commented Mar 4, 2020

Much better. :)

@potiuk potiuk merged commit 09fea3c into apache:master Mar 4, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@turbaszek @galuszkak
[AIRFLOW-6977] Fix BigQuery DTS example DAG (apache#7612)
651bcd5
@turbaszek turbaszek deleted the AIRFLOW-6977-bigquery-dts-example branch March 14, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mik-laj mik-laj mik-laj approved these changes

Assignees

No one assigned

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@turbaszek @codecov-io @michalslowikowski00 @mik-laj @potiuk