[AIRFLOW-6894] Prevent DB query in example_dags #7516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84df80c to
41ce068
Compare
mik-laj
commented
Feb 23, 2020
tests/test_utils/asserts.py
Outdated
Member
Author
There was a problem hiding this comment.
I want to use this decorator also to prevent regression in scheduler performance. Some methods are critical and I have optimized it to use very few queries, but it can be easily broken. This context manager will allow us to detect a regression regarding it.
turbaszek
approved these changes
Feb 23, 2020
kaxil
approved these changes
Feb 23, 2020
41ce068 to
7a3707f
Compare
Codecov Report
@@ Coverage Diff @@
## master #7516 +/- ##
==========================================
- Coverage 86.79% 86.53% -0.27%
==========================================
Files 887 893 +6
Lines 41976 42191 +215
==========================================
+ Hits 36432 36508 +76
- Misses 5544 5683 +139
Continue to review full report at Codecov.
|
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @kaxil @nuclearpinguin
@ANiteckiP Dear SQLAlchemy expert. Do you want to add something?
Issue link: AIRFLOW-6894
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.