[AIRFLOW-6863] Make airflow/task and airflow/ti_deps pylint compatible #7482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
commented
Feb 21, 2020
airflow/ti_deps/deps/base_ti_dep.py
Outdated
Member
Author
There was a problem hiding this comment.
Yes, we had cyclic import...
Cyclic import (airflow.ti_deps.dep_context -> airflow.ti_deps.deps.dag_unpaused_dep -> airflow.ti_deps.deps.base_ti_dep) (cyclic-import)
turbaszek
commented
Feb 21, 2020
scripts/ci/pylint_todo.txt
Outdated
a50b7b2 to
9ea31b5
Compare
9ea31b5 to
bfdf5ab
Compare
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #7482 +/- ##
==========================================
- Coverage 86.69% 86.37% -0.33%
==========================================
Files 883 884 +1
Lines 41645 41650 +5
==========================================
- Hits 36106 35977 -129
- Misses 5539 5673 +134
Continue to review full report at Codecov.
|
mik-laj
approved these changes
Feb 21, 2020
mik-laj
approved these changes
Feb 21, 2020
kaxil
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some pylint errors and moves
*_DEPSfromairflow/ti_deps/dep_context.pytoairflow/ti_dep/dependencies.pyto avoid cyclic import.Issue link: AIRFLOW-6863
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.