Apply AIR201-style replacements#65197
Merged
Merged
Conversation
21ebd83 to
cdd937d
Compare
eladkal
reviewed
Apr 14, 2026
Lee-W
reviewed
Apr 16, 2026
Lee-W
reviewed
Apr 17, 2026
Lee-W
reviewed
Apr 17, 2026
Lee-W
left a comment
Member
There was a problem hiding this comment.
a few style to be unify, but mostly good
d5de52a to
1bd9f4e
Compare
Lee-W
reviewed
Apr 17, 2026
Lee-W
reviewed
Apr 28, 2026
Lee-W
approved these changes
Apr 28, 2026
uranusjr
reviewed
Apr 28, 2026
uranusjr
reviewed
Apr 28, 2026
uranusjr
reviewed
Apr 28, 2026
uranusjr
reviewed
Apr 28, 2026
Collaborator
Author
|
Made another pass. Some patterns like # xcom_arg.py:216-220
def __getitem__(self, item: str) -> XComArg:
if not isinstance(item, str):
raise ValueError(f"XComArg only supports str lookup, received {type(item).__name__}")
return PlainXComArg(operator=self.operator, key=item)So |
Of these, 3 were detected using ruff, and the rest using the below regex:
- Find: \{\{(\s?)task_instance\.xcom_pull\('([^']+)'\)
- Find: \{\{(\s?)ti\.xcom_pull\('([^']+)'\)
- Replace: {{$1$2.output
Each substitution now includes a comment showing the old task_instance.xcom_pull() or ti.xcom_pull() pattern for clarity during code review and historical reference. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Co-Authored-By: GPT 5.4 Mini <codex@openai.com>
shahar1
approved these changes
May 3, 2026
79 tasks
shahar1
pushed a commit
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Of these, 3 were detected using ruff, and the rest using the below regex:
\{\{(\s?)task_instance\.xcom_pull\('([^']+)'\){{$1$2.outputWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.