Improve Playwright test patterns in pools.spec.ts #63430#64328
Merged
choo121600 merged 2 commits intoMar 31, 2026
Merged
Conversation
choo121600
reviewed
Mar 30, 2026
08345e6 to
939db7c
Compare
939db7c to
3faa85c
Compare
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Apr 3, 2026
…e#64328) Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
…e#64328) Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Playwright test patterns in
PoolsPage.tsto align with best practices.waitForLoadState("networkidle")with UI-state assertionswaitForTimeout()in favor of web-first assertionsinput[name="name"],input[type="number"],textarea) withgetByLabel()page.locator('[data-testid="card-list"]')withpage.getByTestId("card-list")closes: #63430