Skip to content

Improve Playwright test patterns in TaskInstancePage #63963#63970

Merged
choo121600 merged 1 commit into
apache:mainfrom
haseebmalik18:e2e/improve-task-instances-test-patterns
Mar 20, 2026
Merged

Improve Playwright test patterns in TaskInstancePage #63963#63970
choo121600 merged 1 commit into
apache:mainfrom
haseebmalik18:e2e/improve-task-instances-test-patterns

Conversation

@haseebmalik18

Copy link
Copy Markdown
Contributor

Replace :has-text() CSS pseudo-selectors with getByTestId() locators in TaskInstancePage.ts to align with Playwright best practices. Added data-testid="trigger-dag-submit" to the trigger form submit button in TriggerDAGForm.tsx.

closes: #63963

@choo121600 choo121600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
LGTM, Thanks

@choo121600 choo121600 merged commit dd015d9 into apache:main Mar 20, 2026
149 of 150 checks passed
fat-catTW pushed a commit to fat-catTW/airflow that referenced this pull request Mar 22, 2026
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
abhijeets25012-tech pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E: Improve Playwright test patterns in specs/task-instances.spec.ts

2 participants