feat: Improve Playwright test patterns in plugins.spec.ts and PluginsPage.ts#63562
Merged
choo121600 merged 5 commits intoMar 17, 2026
Merged
feat: Improve Playwright test patterns in plugins.spec.ts and PluginsPage.ts#63562choo121600 merged 5 commits into
choo121600 merged 5 commits into
Conversation
Contributor
Author
|
@choo121600 Could you please review this PR? |
Contributor
Author
|
@haseebmalik18 Thanks for your feedback! |
Contributor
Author
|
@choo121600 @haseebmalik18 Please review again |
Contributor
Author
|
@choo121600 Review again. I updated |
8 tasks
choo121600
reviewed
Mar 16, 2026
choo121600
left a comment
Member
There was a problem hiding this comment.
Overall looks good to me :)
Let's wait for CI to pass.
choo121600
reviewed
Mar 16, 2026
…2e-improve-playwright-patterns-plugins
Contributor
Author
|
@choo121600 All tests passed! |
Contributor
Author
|
@choo121600 could you also review this PR, too? |
Contributor
Author
|
Thanks. would you merge this PR? 🙏 |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Member
|
@bittoby. Merged :) |
fat-catTW
pushed a commit
to fat-catTW/airflow
that referenced
this pull request
Mar 22, 2026
…Page.ts (apache#63562) * feat: Improve Playwright test patterns in plugins.spec.ts and PluginsPage.ts * refactor: Refactor waitForLoad to use web-first assertions * fix: add data-testid * fix: update web-first assertion
techcodie
pushed a commit
to techcodie/airflow
that referenced
this pull request
Mar 23, 2026
…Page.ts (apache#63562) * feat: Improve Playwright test patterns in plugins.spec.ts and PluginsPage.ts * refactor: Refactor waitForLoad to use web-first assertions * fix: add data-testid * fix: update web-first assertion
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
…Page.ts (apache#63562) * feat: Improve Playwright test patterns in plugins.spec.ts and PluginsPage.ts * refactor: Refactor waitForLoad to use web-first assertions * fix: add data-testid * fix: update web-first assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Playwright test patterns in
plugins.spec.tsandPluginsPage.tsto align with Playwright Best Practices.This PR improves test patterns only. It does not change test coverage or behavior.
Changes in
PluginsPage.ts:page.waitForFunction()with DOM queries with locator-basedwaitFor()nameColumnandsourceColumnas typedLocatorproperties instead of methods returningstring[]Changes in
plugins.spec.ts:not.toHaveCount(),not.toBeEmpty(),toHaveCount())related: #63429
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-sonnet-4-6) following the guidelines