Skip to content

Respect deprecated options in default config parser#61289

Merged
potiuk merged 4 commits into
apache:mainfrom
jason810496:refactor/config/respect-deprecated-for-default-parser
Feb 3, 2026
Merged

Respect deprecated options in default config parser#61289
potiuk merged 4 commits into
apache:mainfrom
jason810496:refactor/config/respect-deprecated-for-default-parser

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

Previously, the default value parser logic in AirflowConfigParser did not check for version_deprecated or deprecation_reason for default config.yaml

This means that if we really deprecated a [config/key], like the case of #56150 (comment) (not renaming or moving to other section like AF2 -to AF3), the conf.get will still get default value from the config.yaml.

From my perspective, the default value parser should respect deprecated options (the option that provide either version_deprecated or deprecation_reason) and ignore it.

What

  • Update the config parser to respect deprecated options for default value parser
  • Extract the configure_parser_from_configuration_description logic to shared lib
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Copilot (ChatGPT 4.1), Gemini-CLI (auto model) following the guidelines

Comment thread shared/configuration/src/airflow_shared/configuration/parser.py
Comment thread shared/configuration/src/airflow_shared/configuration/parser.py
Comment thread shared/configuration/tests/configuration/test_parser.py Outdated

@xBis7 xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jason810496! Changes LGTM!

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@potiuk potiuk force-pushed the refactor/config/respect-deprecated-for-default-parser branch from 729b62f to 88e859a Compare February 3, 2026 12:27
@potiuk potiuk merged commit ff3f61a into apache:main Feb 3, 2026
102 checks passed
Alok-kumar-priyadarshi pushed a commit to Alok-kumar-priyadarshi/airflow that referenced this pull request Feb 5, 2026
* Refactor configuration parser to respect deprecated options in default parser

* Add tests to ensure deprecated options are skipped in configuration parser

* Add test for handling default values of deprecated options in AirflowConfigParser

* Add test case without fallback param
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
* Refactor configuration parser to respect deprecated options in default parser

* Add tests to ensure deprecated options are skipped in configuration parser

* Add test for handling default values of deprecated options in AirflowConfigParser

* Add test case without fallback param
Ratasa143 pushed a commit to Ratasa143/airflow that referenced this pull request Feb 15, 2026
* Refactor configuration parser to respect deprecated options in default parser

* Add tests to ensure deprecated options are skipped in configuration parser

* Add test for handling default values of deprecated options in AirflowConfigParser

* Add test case without fallback param
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
* Refactor configuration parser to respect deprecated options in default parser

* Add tests to ensure deprecated options are skipped in configuration parser

* Add test for handling default values of deprecated options in AirflowConfigParser

* Add test case without fallback param
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
* Refactor configuration parser to respect deprecated options in default parser

* Add tests to ensure deprecated options are skipped in configuration parser

* Add test for handling default values of deprecated options in AirflowConfigParser

* Add test case without fallback param
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
* Refactor configuration parser to respect deprecated options in default parser

* Add tests to ensure deprecated options are skipped in configuration parser

* Add test for handling default values of deprecated options in AirflowConfigParser

* Add test case without fallback param
radhwene pushed a commit to radhwene/airflow that referenced this pull request Mar 21, 2026
* Refactor configuration parser to respect deprecated options in default parser

* Add tests to ensure deprecated options are skipped in configuration parser

* Add test for handling default values of deprecated options in AirflowConfigParser

* Add test case without fallback param
xBis7 added a commit to xBis7/airflow that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants