Skip to content

Select filepath using cursor in Import Errors in the UI #61011

Merged
pierrejeambrun merged 1 commit into
apache:mainfrom
sarth-akvaish:fix/path-from-import-error
Feb 5, 2026
Merged

Select filepath using cursor in Import Errors in the UI #61011
pierrejeambrun merged 1 commit into
apache:mainfrom
sarth-akvaish:fix/path-from-import-error

Conversation

@sarth-akvaish

@sarth-akvaish sarth-akvaish commented Jan 24, 2026

Copy link
Copy Markdown
Contributor

This PR improved the DAG Import Errors modal to make the full DAG file path selectable and copyable.

Fixes : #54125

Updated using Collapsible

Screencast.from.2026-01-31.20-16-33.mp4

Video

Screencast.from.2026-02-01.12-49-19.mp4

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 24, 2026

@guan404ming guan404ming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Functional wise looks good, left one question.

@sarth-akvaish sarth-akvaish force-pushed the fix/path-from-import-error branch from f25518f to c272cf3 Compare January 31, 2026 14:51
@sarth-akvaish

sarth-akvaish commented Jan 31, 2026

Copy link
Copy Markdown
Contributor Author

Hi @guan404ming , can you review the updated PR

@guan404ming

Copy link
Copy Markdown
Member

Could help attach some demo more you updat? Thanks!

@sarth-akvaish

Copy link
Copy Markdown
Contributor Author

Could help attach some demo more you updat? Thanks!

Hi, Updated the Description. Thanks

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that this now becomes 2 lines for each import errors, and also that the 'collapsible' can only be extended by clicking on the right icon is not ideal I think.

You can instead use something like this, I think it's the best of both worlds. (maybe put the clipboard icon on the right next to the collapsible)

    <ClipboardRoot onClick={(event) => event.stopPropagation()} value={importError.filename}>
        <ClipboardIconButton />
    </ClipboardRoot>
Screen.Recording.2026-02-02.at.11.29.15.mov

@sarth-akvaish

Copy link
Copy Markdown
Contributor Author

The fact that this now becomes 2 lines for each import errors, and also that the 'collapsible' can only be extended by clicking on the right icon is not ideal I think.

You can instead use something like this, I think it's the best of both worlds. (maybe put the clipboard icon on the right next to the collapsible)

Yes, This seems much cleaner in terms of UI, will fix it and update the PR soon

@sarth-akvaish sarth-akvaish force-pushed the fix/path-from-import-error branch from c272cf3 to a627adf Compare February 2, 2026 16:10
@sarth-akvaish

Copy link
Copy Markdown
Contributor Author

Updated the PR

Screencast.from.2026-02-02.21-34-20.mp4

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better.

I think there is unneeded change.

When I tested this locally only a handful of lines changed were enough. (Not sure about that vstack, I'll try this tomorrow

@sarth-akvaish sarth-akvaish force-pushed the fix/path-from-import-error branch from a627adf to aa11d09 Compare February 4, 2026 16:14
@sarth-akvaish

Copy link
Copy Markdown
Contributor Author

Removed unneeded code(Collapsible code for each error row, due to which error file details was showing in two lines)

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.8 milestone Feb 5, 2026
@pierrejeambrun pierrejeambrun merged commit 00b8809 into apache:main Feb 5, 2026
78 checks passed
github-actions Bot pushed a commit that referenced this pull request Feb 5, 2026
(cherry picked from commit 00b8809)

Co-authored-by: Sarthak Vaish <108884904+sarth-akvaish@users.noreply.github.com>
@github-actions

github-actions Bot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Feb 5, 2026
(cherry picked from commit 00b8809)

Co-authored-by: Sarthak Vaish <108884904+sarth-akvaish@users.noreply.github.com>
guan404ming pushed a commit that referenced this pull request Feb 6, 2026
(cherry picked from commit 00b8809)

Co-authored-by: Sarthak Vaish <108884904+sarth-akvaish@users.noreply.github.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Ratasa143 pushed a commit to Ratasa143/airflow that referenced this pull request Feb 15, 2026
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
vatsrahul1001 pushed a commit that referenced this pull request Mar 4, 2026
(cherry picked from commit 00b8809)

Co-authored-by: Sarthak Vaish <108884904+sarth-akvaish@users.noreply.github.com>
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
radhwene pushed a commit to radhwene/airflow that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't select DAG path in UI from dag imports error list

3 participants