Select filepath using cursor in Import Errors in the UI #61011
Conversation
guan404ming
left a comment
There was a problem hiding this comment.
Thanks! Functional wise looks good, left one question.
f25518f to
c272cf3
Compare
|
Hi @guan404ming , can you review the updated PR |
|
Could help attach some demo more you updat? Thanks! |
Hi, Updated the Description. Thanks |
There was a problem hiding this comment.
The fact that this now becomes 2 lines for each import errors, and also that the 'collapsible' can only be extended by clicking on the right icon is not ideal I think.
You can instead use something like this, I think it's the best of both worlds. (maybe put the clipboard icon on the right next to the collapsible)
<ClipboardRoot onClick={(event) => event.stopPropagation()} value={importError.filename}>
<ClipboardIconButton />
</ClipboardRoot>Screen.Recording.2026-02-02.at.11.29.15.mov
Yes, This seems much cleaner in terms of UI, will fix it and update the PR soon |
c272cf3 to
a627adf
Compare
|
Updated the PR Screencast.from.2026-02-02.21-34-20.mp4 |
a627adf to
aa11d09
Compare
|
Removed unneeded code(Collapsible code for each error row, due to which error file details was showing in two lines) |
(cherry picked from commit 00b8809) Co-authored-by: Sarthak Vaish <108884904+sarth-akvaish@users.noreply.github.com>
(cherry picked from commit 00b8809) Co-authored-by: Sarthak Vaish <108884904+sarth-akvaish@users.noreply.github.com>
This PR improved the DAG Import Errors modal to make the full DAG file path selectable and copyable.
Fixes : #54125
Updated using Collapsible
Screencast.from.2026-01-31.20-16-33.mp4
Video
Screencast.from.2026-02-01.12-49-19.mp4
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.