Feat e2e test for Dags pagination#59400
Conversation
pierrejeambrun
left a comment
There was a problem hiding this comment.
LGTM
Just one nit to make it easier for follow up PRs:
Can we put that into a airflow-core/src/airflow/ui/tests/e2e/specs/dags-list.spec.ts file.
Similarly to https://github.com/apache/airflow/pull/59374 so all daglist related tests are in the same file.
|
Nice! @choo121600 We noticed all of the UI e2e test skipped as |
Yeah agree with @pierrejeambrun all of test realted to dag list should be in a file |
|
Now all of the UI e2e tests ran fine. |
|
CI failure that I don’t understand why👀 |
|
I think |
Yes, should be in |
Was due to Sphinx. Fixed after merging #59538 |
Yes, once this PR is merged, I’ll move it in a separate PR ;) |
Feat e2e test for Dags pagination
Feat e2e test for Dags pagination
Address review feedback from PR apache#59400: - Use data-testid selectors instead of page numbers - Remove conditional checks for pagination - Verify data actually changes with expect.poll()
Feat e2e test for Dags pagination
Feat e2e test for Dags pagination
E2E test to verify pagination functionality on the Dags list page.
Add
dags-pagination.spec.tsE2E test that verifies:closes: #59308
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.