Add revoke_task implementation to EdgeExecutor for task queued timeout support#56240
Merged
jscheffl merged 2 commits intoOct 1, 2025
Merged
Conversation
…t to raise NotImplementedError when the scheduler attempted to handle tasks stuck in queued state. This meant the task_queued_timeout feature was completely bypassed for EdgeExecutor. This commit implements revoke_task() to: - Remove tasks from executor's internal state (running, queued_tasks, last_reported_state) - Delete corresponding EdgeJobModel records to prevent edge workers from picking them up - Enable proper task queued timeout handling by the scheduler Added tests to verify revoke_task correctly removes tasks from both executor state and database, and handles non-existent tasks gracefully.
jscheffl
reviewed
Sep 30, 2025
jscheffl
approved these changes
Sep 30, 2025
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this! So far did not notice and seems we did not have failed tasks in queue so far in our setup :-D
One nit in regards to commit(), else LGTM!
…cutor.py Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
…t support (apache#56240) * EdgeExecutor was not implementing the revoke_task() method, causing it to raise NotImplementedError when the scheduler attempted to handle tasks stuck in queued state. This meant the task_queued_timeout feature was completely bypassed for EdgeExecutor. This commit implements revoke_task() to: - Remove tasks from executor's internal state (running, queued_tasks, last_reported_state) - Delete corresponding EdgeJobModel records to prevent edge workers from picking them up - Enable proper task queued timeout handling by the scheduler Added tests to verify revoke_task correctly removes tasks from both executor state and database, and handles non-existent tasks gracefully. * Update providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
69 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EdgeExecutor was not implementing the revoke_task() method, causing it to raise NotImplementedError when the scheduler attempted to handle tasks stuck in queued state. This meant the task_queued_timeout feature was completely bypassed for EdgeExecutor.
This commit implements revoke_task() to:
Before:
After:
