Change the signature of BaseDBManager downgrade method#55907
Merged
Conversation
This changes the signature of BaseDBManager.downgrade to use revision instead of version args. This aligns it with the upgradedb method and fixes issue where the db manager downgrade command was calling the downgrade with revision instead of version. This is going to be a breaking change but I doubt there's usages of this in the wild cause there's a bug and no one noticed till now.
kaxil
approved these changes
Sep 19, 2025
eladkal
approved these changes
Sep 20, 2025
KatalKavya96
pushed a commit
to KatalKavya96/airflow
that referenced
this pull request
Sep 22, 2025
kaxil
pushed a commit
that referenced
this pull request
Sep 23, 2025
(cherry picked from commit bff6c95)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the signature of BaseDBManager.downgrade to use revision instead of version args. This aligns it with the upgradedb method and fixes issue where the db manager downgrade command was calling the downgrade with revision instead of version. This is going to be a breaking change but I doubt there's usages of this in the wild cause there's a bug and no one noticed till now.