Fall back to stringification for XCom#55880
Merged
Merged
Conversation
3e1b943 to
8162670
Compare
Lee-W
approved these changes
Sep 19, 2025
pierrejeambrun
approved these changes
Sep 19, 2025
Member
|
Maybe a small test could help prevent regression in the future |
Even when stringify=false, we still need to make sure we have something serializable to return in the API response. If the XCom value can't work, we should still stringify it so the API can return something. This was what API v1 did in Airflow 2.x.
8162670 to
985b5bf
Compare
vatsrahul1001
approved these changes
Sep 19, 2025
kaxil
pushed a commit
that referenced
this pull request
Sep 19, 2025
Even when stringify=false, we still need to make sure we have something serializable to return in the API response. If the XCom value can't work, we should still stringify it so the API can return something. This was what API v1 did in Airflow 2.x. (cherry picked from commit e4ea69c)
KatalKavya96
pushed a commit
to KatalKavya96/airflow
that referenced
this pull request
Sep 22, 2025
Even when stringify=false, we still need to make sure we have something serializable to return in the API response. If the XCom value can't work, we should still stringify it so the API can return something. This was what API v1 did in Airflow 2.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even when stringify=false, we still need to make sure we have something serializable to return in the API response. If the XCom value can't work, we should still stringify it so the API can return something.
This was what API v1 did in Airflow 2.x.
Fix #55781.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.