Skip to content

Fix:added none to lastupdated Date if event is not in queue#54652

Merged
kaxil merged 6 commits into
apache:mainfrom
vikrantkumar-max:fix/53817-asset-queue-on-dag-page-fix
Sep 19, 2025
Merged

Fix:added none to lastupdated Date if event is not in queue#54652
kaxil merged 6 commits into
apache:mainfrom
vikrantkumar-max:fix/53817-asset-queue-on-dag-page-fix

Conversation

@vikrantkumar-max

Copy link
Copy Markdown
Contributor

closes: #53817

Summary of changes:

Display logic for "X of Y assets":

Y = total assets relevant to the DAG's asset_expression.

X = assets with lastUpdate > latestRunAfter (i.e., new events since last DAG run).

Introduced SQL-based computation of each asset’s "queued" status using a LEFT JOIN + MAX(CASE) approach.

Grouped and normalized the data so:

Non-queued assets have lastUpdate = None.

The internal queued field is removed from the final response payload for clarity.

@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label Aug 19, 2025
@vikrantkumar-max vikrantkumar-max changed the title Fix:added none to lastupdatedDate if event is not in queue Fix:added none to lastupdated Date if event is not in queue Aug 19, 2025

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

One nit, looking good otherwise.

Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/ui/assets.py Outdated
Comment thread airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_assets.py Outdated
Comment thread airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_assets.py Outdated
@vikrantkumar-max vikrantkumar-max force-pushed the fix/53817-asset-queue-on-dag-page-fix branch 2 times, most recently from b6adbcd to 1df9592 Compare September 5, 2025 11:09
@eladkal

eladkal commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

@eladkal eladkal modified the milestones: Airflow 3.0.7, Airflow 3.1.0 Sep 10, 2025
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Sep 10, 2025
@eladkal eladkal requested a review from kaxil September 10, 2025 06:44
@kaxil kaxil requested review from Lee-W and uranusjr September 11, 2025 07:14

@Lee-W Lee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good, some nit

Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/ui/assets.py Outdated
Comment thread airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_assets.py Outdated
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/ui/assets.py Outdated
@eladkal eladkal force-pushed the fix/53817-asset-queue-on-dag-page-fix branch from 00c59f0 to 60576cb Compare September 15, 2025 15:09
@Lee-W Lee-W force-pushed the fix/53817-asset-queue-on-dag-page-fix branch from f344804 to 9d17010 Compare September 18, 2025 12:11
@kaxil kaxil force-pushed the fix/53817-asset-queue-on-dag-page-fix branch from 9d17010 to a3ff29b Compare September 18, 2025 20:43
@kaxil kaxil modified the milestones: Airflow 3.1.0, Airflow 3.1.1 Sep 19, 2025
@kaxil

kaxil commented Sep 19, 2025

Copy link
Copy Markdown
Member

Static check failed

Comment thread airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_assets.py Outdated
@eladkal

eladkal commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Should pass the static checks now

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready to merge when CI is happy.

@kaxil kaxil merged commit f9400cc into apache:main Sep 19, 2025
105 checks passed
@kaxil kaxil modified the milestones: Airflow 3.1.1, Airflow 3.1.0 Sep 19, 2025
kaxil pushed a commit that referenced this pull request Sep 19, 2025
KatalKavya96 pushed a commit to KatalKavya96/airflow that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleted queued asset events for a DAG not reflected in the UI

5 participants