[AIRFLOW-4750] Log identified zombie task instances#5389
Merged
ashb merged 1 commit intoapache:masterfrom Jun 13, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5389 +/- ##
==========================================
+ Coverage 78.75% 78.94% +0.18%
==========================================
Files 481 481
Lines 30201 30203 +2
==========================================
+ Hits 23786 23843 +57
+ Misses 6415 6360 -55
Continue to review full report at Codecov.
|
ashb
requested changes
Jun 11, 2019
e846903 to
b1d7732
Compare
ashb
approved these changes
Jun 12, 2019
tooptoop4
suggested changes
Jun 12, 2019
Contributor
tooptoop4
left a comment
There was a problem hiding this comment.
Log does not have the word zombie?
ashb
requested changes
Jun 12, 2019
Member
ashb
left a comment
There was a problem hiding this comment.
As pointed out by tooptoop4 (and lets make the dates logged by iso8601 format rather than "almost")
b1d7732 to
d3ad93f
Compare
Contributor
Author
|
Good recommendations. I've adjusted the language a bit and added isoformat. Thanks |
ashb
approved these changes
Jun 13, 2019
ashb
pushed a commit
that referenced
this pull request
Jun 13, 2019
(cherry picked from commit d89c17d)
tiopi
pushed a commit
to tiopi/airflow
that referenced
this pull request
Jun 14, 2019
# This is the 1st commit message: [AIRFLOW-4750] Log identified zombie task instances (apache#5389) # This is the commit message apache#2: Added Sentry to contrib folder # This is the commit message apache#3: Added Sentry to contrib folder
tiopi
pushed a commit
to tiopi/airflow
that referenced
this pull request
Jun 14, 2019
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Jun 18, 2019
(cherry picked from commit d89c17d)
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
dharamsk
pushed a commit
to postmates/airflow
that referenced
this pull request
Aug 8, 2019
(cherry picked from commit d89c17d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
While troubleshooting task instances that were unexpectedly killed I found it helpful to confirm whether the task was identified as a zombie by printing to log.
Tests
Commits
Documentation
Code Quality
flake8