Fix backward compatibility for timeout in defer() with Airflow 2.11#50869
Merged
eladkal merged 2 commits intoapache:mainfrom May 21, 2025
Merged
Fix backward compatibility for timeout in defer() with Airflow 2.11#50869eladkal merged 2 commits intoapache:mainfrom
eladkal merged 2 commits intoapache:mainfrom
Conversation
eladkal
reviewed
May 21, 2025
uranusjr
approved these changes
May 21, 2025
Lee-W
approved these changes
May 21, 2025
eladkal
approved these changes
May 21, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
May 21, 2025
…pache#50869) * Remove 2.11 backcompat code in time delta operators to fix CI * fix compat logic
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
…pache#50869) * Remove 2.11 backcompat code in time delta operators to fix CI * fix compat logic
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…pache#50869) * Remove 2.11 backcompat code in time delta operators to fix CI * fix compat logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is failing with errors like these:
In 2.11, timeout must be a
timedelta | NoneIn 3.0, timeout can be
timedelta | int | float | NoneIt seems the conditional is wrong and should be flipped
Example failures: https://github.com/apache/airflow/actions/runs/15152977665/job/42602642810
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.