Merged
Conversation
These were outdated. Still need to automate this process!
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Python client's documentation and test code to reflect the new recommended authentication approach.
- Updated the configuration instantiation to include an access token
- Removed manual authorization header settings from the ApiClient instance
Comments suppressed due to low confidence (2)
clients/python/test_python_client.py:66
- Verify that setting the access_token directly in the Configuration object correctly configures the ApiClient for authentication without needing the manual header parameters.
configuration = airflow_client.client.Configuration(host="http://localhost:8080", access_token=access_token)
clients/python/test_python_client.py:76
- Confirm that the ApiClient no longer requires explicit header_name and header_value parameters, and that all scenarios use the authentication configured in the Configuration object.
with airflow_client.client.ApiClient(configuration) as api_client:
vincbeck
approved these changes
May 20, 2025
potiuk
approved these changes
May 20, 2025
kaxil
added a commit
to apache/airflow-client-python
that referenced
this pull request
May 20, 2025
These were outdated. Still need to automate this process! (From apache/airflow#50850)
kaxil
added a commit
to apache/airflow-client-python
that referenced
this pull request
May 20, 2025
These were outdated. Still need to automate this process! (From apache/airflow#50850)
kaxil
added a commit
to apache/airflow-client-python
that referenced
this pull request
May 20, 2025
These were outdated. Still need to automate this process! (From apache/airflow#50850)
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
May 21, 2025
These were outdated. Still need to automate this process!
kaxil
added a commit
that referenced
this pull request
May 23, 2025
These were outdated. Still need to automate this process! (cherry picked from commit 687decf)
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
These were outdated. Still need to automate this process!
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
These were outdated. Still need to automate this process!
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 10, 2025
These were outdated. Still need to automate this process! (cherry picked from commit 687decf)
Member
|
manual cherry pick PR |
pierrejeambrun
added a commit
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were outdated. Still need to automate this process!
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.