Enable Comms in the TriggerRunner to make Connections, Variables and XComs accessible to Triggers#48239
Merged
pierrejeambrun merged 16 commits intoMar 31, 2025
Merged
Conversation
2 tasks
Member
Author
|
cc: @dstandish |
pierrejeambrun
commented
Mar 25, 2025
0c0521a to
e3a3ea0
Compare
ashb
reviewed
Mar 25, 2025
ashb
left a comment
Member
There was a problem hiding this comment.
Yes the approach looks about right.
I'm a little concerned about the interleaving/mixign of cancel and conn response messages in the async side read. Let me re-read that code
f068d12 to
759ff89
Compare
Member
Author
|
Can also retrieve Variables. |
kaxil
reviewed
Mar 26, 2025
kaxil
reviewed
Mar 26, 2025
Member
|
Triggering tests.. |
d134e29 to
d2d9553
Compare
Member
Author
|
Well that's progress. It seems that there's still one side effect to fix on |
d2d9553 to
d11954f
Compare
d11954f to
65f90f9
Compare
pierrejeambrun
commented
Mar 31, 2025
Member
|
Thank you @pierrejeambrun for working on this. I am now able to use connections in triggerer and the DAG is running fine with deferral mode 👏🏽 |
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
…XComs accessible to Triggers (apache#48239) * Init triggerer comms * Remove cache from in_process_api_server * Add lock for trigger threads to wait for their messages * Move comms init code to TriggerRunner class * Add TODO for empty line investigation * Update kind to type for common discriminator * Add test, add xcom handling * Address PR comments * Rename test supervisor class * Add XCom test and code * Fix following code review * Fix CI and add comment * Update task-sdk/src/airflow/sdk/api/client.py * Small adjustments * Remove unused fixture * Fix CI
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…XComs accessible to Triggers (apache#48239) * Init triggerer comms * Remove cache from in_process_api_server * Add lock for trigger threads to wait for their messages * Move comms init code to TriggerRunner class * Add TODO for empty line investigation * Update kind to type for common discriminator * Add test, add xcom handling * Address PR comments * Rename test supervisor class * Add XCom test and code * Fix following code review * Fix CI and add comment * Update task-sdk/src/airflow/sdk/api/client.py * Small adjustments * Remove unused fixture * Fix CI
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
…XComs accessible to Triggers (apache#48239) * Init triggerer comms * Remove cache from in_process_api_server * Add lock for trigger threads to wait for their messages * Move comms init code to TriggerRunner class * Add TODO for empty line investigation * Update kind to type for common discriminator * Add test, add xcom handling * Address PR comments * Rename test supervisor class * Add XCom test and code * Fix following code review * Fix CI and add comment * Update task-sdk/src/airflow/sdk/api/client.py * Small adjustments * Remove unused fixture * Fix CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #48183
Init the comms to be able to retrieve connections, variables and xcoms from the Trigger.