Skip to content

feat(AIP-84): Add Auth for ui assets#47485

Merged
pierrejeambrun merged 4 commits into
apache:mainfrom
astronomer:feature/AIP-84/auth/ui/assets
Mar 10, 2025
Merged

feat(AIP-84): Add Auth for ui assets#47485
pierrejeambrun merged 4 commits into
apache:mainfrom
astronomer:feature/AIP-84/auth/ui/assets

Conversation

@Lee-W

@Lee-W Lee-W commented Mar 7, 2025

Copy link
Copy Markdown
Member

Why

#42360


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label Mar 7, 2025
@Lee-W Lee-W mentioned this pull request Mar 7, 2025
47 tasks
@Lee-W Lee-W force-pushed the feature/AIP-84/auth/ui/assets branch from 9279064 to b52ff68 Compare March 7, 2025 09:36
@Lee-W Lee-W added the full tests needed We need to run full set of tests for this PR to merge label Mar 7, 2025

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment otherwise looking good. We can merge after that.

Comment thread airflow/api_fastapi/core_api/openapi/v1-generated.yaml Outdated
@Lee-W Lee-W force-pushed the feature/AIP-84/auth/ui/assets branch from b52ff68 to 7d0b8c1 Compare March 7, 2025 14:41

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is expected, those were wrongfully added because of the decorator.

Comment thread airflow/api_fastapi/core_api/routes/ui/assets.py Outdated
@Lee-W Lee-W marked this pull request as draft March 7, 2025 15:22
@Lee-W Lee-W force-pushed the feature/AIP-84/auth/ui/assets branch from 85f9f27 to 33110ea Compare March 10, 2025 09:19
Comment thread airflow/api_fastapi/core_api/security.py Outdated
Comment thread airflow/api_fastapi/core_api/routes/ui/assets.py
@Lee-W Lee-W force-pushed the feature/AIP-84/auth/ui/assets branch 2 times, most recently from cd11013 to 675d635 Compare March 10, 2025 10:55
@Lee-W Lee-W force-pushed the feature/AIP-84/auth/ui/assets branch from 675d635 to 6d00543 Compare March 10, 2025 12:09
@Lee-W Lee-W marked this pull request as ready for review March 10, 2025 13:36
@Lee-W Lee-W requested a review from pierrejeambrun March 10, 2025 13:36
@Lee-W

Lee-W commented Mar 10, 2025

Copy link
Copy Markdown
Member Author

all green 🙌

@pierrejeambrun pierrejeambrun merged commit a26ea38 into apache:main Mar 10, 2025
@pierrejeambrun pierrejeambrun deleted the feature/AIP-84/auth/ui/assets branch March 10, 2025 16:03
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* feat(AIP-84): Add Auth for ui assets

* build: rebuild airflow/api_fastapi/core_api/openapi/v1-generated.yaml

* feat(api_fastapi): remove dag_id param from request_dag_access

* test: fix require_access_dag tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants