Skip to content

Remove deprecated code from Pagerduty provider #44653

Merged
jscheffl merged 4 commits intoapache:mainfrom
Prab-27:remove-deprecated-code-from-pagerduty
Dec 7, 2024
Merged

Remove deprecated code from Pagerduty provider #44653
jscheffl merged 4 commits intoapache:mainfrom
Prab-27:remove-deprecated-code-from-pagerduty

Conversation

@Prab-27
Copy link
Contributor

@Prab-27 Prab-27 commented Dec 4, 2024

related: #44559

remove-deprecated-code, remove test ,update changelog from-pagerduty provider

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

gopidesupavan
gopidesupavan reviewed Dec 5, 2024
View reviewed changes
@jscheffl jscheffl mentioned this pull request Dec 6, 2024
Closed
94 tasks
@jscheffl
Copy link
Contributor

jscheffl commented Dec 7, 2024

Just a static check is failing, when this is fixed I assume this can be merged.

@Prab-27
Copy link
Contributor Author

Prab-27 commented Dec 7, 2024

Just a static check is failing, when this is fixed I assume this can be merged.

I have modified test_pagerduty.py and another check has failed due to this statement from providers/src/airflow/providers/pagerduty/hooks/pagerduty.py
airflow.providers.pagerduty.hooks.pagerduty_events import PagerdutyEventsHook

However, fixing the second static check caused the unit test to fail.

__ ERROR collecting providers/tests/pagerduty/hooks/test_pagerduty_events.py ___
ImportError while importing test module '/opt/airflow/providers/tests/pagerduty/hooks/test_pagerduty_events.py'.
Hint: make sure your test modules/packages have valid Python names.

@jscheffl
Copy link
Contributor

jscheffl commented Dec 7, 2024 •
edited
Loading

Just a static check is failing, when this is fixed I assume this can be merged.

I have modified test_pagerduty.py and another check has failed due to this statement from providers/src/airflow/providers/pagerduty/hooks/pagerduty.py airflow.providers.pagerduty.hooks.pagerduty_events import PagerdutyEventsHook

However, fixing the second static check caused the unit test to fail.

__ ERROR collecting providers/tests/pagerduty/hooks/test_pagerduty_events.py ___
ImportError while importing test module '/opt/airflow/providers/tests/pagerduty/hooks/test_pagerduty_events.py'.
Hint: make sure your test modules/packages have valid Python names.

Yes, because previously the pytest imported "wrong" as a re-import. In providers/tests/pagerduty/hooks/test_pagerduty_events.py:23 you need to import via:

from airflow.providers.pagerduty.hooks.pagerduty_events import PagerdutyEventsHook

...and then of course also commit the fix in static checks, easiest run pre-commit run -a

@Prab-27
Copy link
Contributor Author

Prab-27 commented Dec 7, 2024

Done !

@jscheffl jscheffl merged commit 8cd2f82 into apache:main Dec 7, 2024
@jscheffl
Copy link
Contributor

jscheffl commented Dec 7, 2024

Green! Merged! Thanks!

@eladkal eladkal mentioned this pull request Dec 22, 2024
Closed
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@Prab-27 @got686-yandex
Remove deprecated code from Pagerduty provider (apache#44653)
f734792 
* Remove deprecated code from pagerduty provider and update changelog

* modified changelog from pagerduty

* modified test_pagerduty.py

* modified import statement and fix static check

---------

Co-authored-by: pratiksha rajendrabhai badheka <pratiksha@DESKTOP-T5HUA05>
@hongyiw-oai hongyiw-oai mentioned this pull request Apr 8, 2025
Closed
2 tasks
@whynick1 whynick1 mentioned this pull request Apr 8, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gopidesupavan gopidesupavan gopidesupavan left review comments

@potiuk potiuk potiuk approved these changes

Assignees

No one assigned

Labels

area:providers provider:pagerduty

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Prab-27 @jscheffl @potiuk @gopidesupavan