Removed deprecated code from Alibaba provider package#44576
Merged
potiuk merged 2 commits intoapache:mainfrom Dec 16, 2024
Merged
Removed deprecated code from Alibaba provider package#44576potiuk merged 2 commits intoapache:mainfrom
potiuk merged 2 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
94 tasks
shahar1
approved these changes
Dec 3, 2024
shahar1
reviewed
Dec 3, 2024
Contributor
shahar1
left a comment
There was a problem hiding this comment.
Welcome to Apache Airflow and thank you for your contribution, great job!
Could you please remove the now redundant imports? :)
providers/src/airflow/providers/alibaba/cloud/operators/analyticdb_spark.py
Outdated
Show resolved
Hide resolved
providers/src/airflow/providers/alibaba/cloud/sensors/analyticdb_spark.py
Outdated
Show resolved
Hide resolved
Member
|
That's the LAST one @Tushar4432 -> shall you rebase/apply the comments so that we can close #44559 🚀 ? |
1de66ad to
405e723
Compare
removed depricated code from alibaba provider
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
405e723 to
3f69dde
Compare
potiuk
approved these changes
Dec 16, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* issue 44559 removed depricated code from alibaba provider * Apply suggestions from code review Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #44559
Removed deprecated code from the Alibaba providers.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.