Add dependency to httpx >= 0.25.0 everywhere#40256
Merged
potiuk merged 1 commit intoapache:mainfrom Jun 15, 2024
Merged
Conversation
Our "lowest-dependency" tests detectaed that weaviate client depends implicitly on httpx >= 0.19.0 (imports USE_CLIENT_DEFAULTS from httpx and it's missing < 0.19.0). Howeer this error is raised during importing of examples for weaviate in "Always" tests, and closer look at weaviate shows that it actually has >=0.25.0 and it makes sense for all our providers to bump httpx to 0.25.0 as minimum as well as add it to weaviate explicitly..
ephraimbuddy
approved these changes
Jun 15, 2024
hussein-awala
approved these changes
Jun 15, 2024
52 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Our "lowest-dependency" tests detectaed that weaviate client depends implicitly on httpx >= 0.19.0 (imports USE_CLIENT_DEFAULTS from httpx and it's missing < 0.19.0). Howeer this error is raised during importing of examples for weaviate in "Always" tests, and closer look at weaviate shows that it actually has >=0.25.0 and it makes sense for all our providers to bump httpx to 0.25.0 as minimum as well as add it to weaviate explicitly..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our "lowest-dependency" tests detectaed that weaviate client depends implicitly on httpx >= 0.19.0 (imports USE_CLIENT_DEFAULTS from httpx and it's missing < 0.19.0). Howeer this error is raised during importing of examples for weaviate in "Always" tests, and closer look at weaviate shows that it actually has >=0.25.0 and it makes sense for all our providers to bump httpx to 0.25.0 as minimum as well as add it to weaviate explicitly..
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.