Skip to content

Delete deprecated AutoML operators (inc. 'google-cloud-automl' dep.) and deprecate hook and links #38418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Mar 24, 2024
Merged

Delete deprecated AutoML operators (inc. 'google-cloud-automl' dep.) and deprecate hook and links #38418

potiuk merged 1 commit into from
Mar 24, 2024

Conversation

@shahar1
Copy link
Contributor

@shahar1 shahar1 commented Mar 22, 2024 •
edited
Loading

Starting March 31, 2024, GCP will sunset the old AutoML API, effectively making the deprecated operators, 'google-cloud-automl' dependency, links and hook unusable. This PR:

  • Removes the AutoML operators (+related tests/docs)
  • Removes the dependency 'google-cloud-automl'
  • Deprecates CloudAutoMLHook
  • Deprecates AutoML links.

The hook and the links haven't been formally deprecated in Airflow, so it might be better to take a bit more cautious approach before removing both, as theoretically someone could import them into their codebase without knowing that they are deprecated.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers area:system-tests provider:google Google (including GCP) related issues labels Mar 22, 2024
@shahar1 shahar1 marked this pull request as draft March 23, 2024 06:26
@shahar1 shahar1 force-pushed the delete-deprecated-automl-operators branch from 141ed6d to ab920d2 Compare March 23, 2024 08:02
@shahar1 shahar1 changed the title Delete deprecated AutoML operators and hook Delete deprecated AutoML operators and deprecate CloudAutoMLHook Mar 23, 2024
@shahar1 shahar1 force-pushed the delete-deprecated-automl-operators branch from ab920d2 to 6af3a9a Compare March 23, 2024 08:22
@shahar1 shahar1 marked this pull request as ready for review March 23, 2024 08:23
@shahar1 shahar1 requested review from ashb and potiuk as code owners March 23, 2024 08:23
@shahar1 shahar1 force-pushed the delete-deprecated-automl-operators branch from 6af3a9a to cbc4a68 Compare March 23, 2024 08:24
@shahar1 shahar1 marked this pull request as draft March 23, 2024 08:41
@shahar1 shahar1 changed the title Delete deprecated AutoML operators and deprecate CloudAutoMLHook Delete deprecated AutoML operators and deprecate hook and links Mar 23, 2024
@shahar1 shahar1 force-pushed the delete-deprecated-automl-operators branch from cbc4a68 to f2c54f2 Compare March 23, 2024 08:59
@shahar1 shahar1 marked this pull request as ready for review March 23, 2024 08:59
shahar1
shahar1 commented Mar 23, 2024
View reviewed changes
@shahar1 shahar1 force-pushed the delete-deprecated-automl-operators branch 2 times, most recently from a19e1bf to 85c0f32 Compare March 23, 2024 09:43
@shahar1 shahar1 changed the title Delete deprecated AutoML operators and deprecate hook and links Delete deprecated AutoML operators (inc. 'google-cloud-automl' dep.) and deprecate hook and links Mar 23, 2024
@shahar1 shahar1 force-pushed the delete-deprecated-automl-operators branch from 85c0f32 to f167253 Compare March 23, 2024 11:29
@shahar1 shahar1 force-pushed the delete-deprecated-automl-operators branch from f167253 to 8c9d191 Compare March 23, 2024 12:55
@potiuk potiuk merged commit 4a4eee1 into apache:main Mar 24, 2024
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 25, 2024
@molcay
Copy link
Contributor

molcay commented Mar 28, 2024

I will be reverting the commit

We want to take a bit of a different approach for depreciation since we did not include depreciation for most of the operators. Removing them without deprecation tends to become a breaking change and also mentioned here.
Also, we can still use most of the operators for AutoML Translate service

@shahar1 shahar1 mentioned this pull request Mar 30, 2024
Merged
shahar1 added a commit to shahar1/airflow that referenced this pull request Mar 30, 2024
@shahar1
Revert "Delete deprecated AutoML operators and deprecate AutoML hook …
b435116 
…and links (apache#38418)"

This reverts commit 4a4eee1
@shahar1
Copy link
Contributor Author

shahar1 commented Mar 30, 2024

I will be reverting the commit

We want to take a bit of a different approach for depreciation since we did not include depreciation for most of the operators. Removing them without deprecation tends to become a breaking change and also mentioned here. Also, we can still use most of the operators for AutoML Translate service

Thanks for pointing it out!
I've been ahead of you and created #38633 to reverse this PR, but I am also working on a patch that will deprecate operators and hooks that become obsolete after GCP shuts AutoML for non-translation models. This deprecation will be "strong" (i.e., raising an error instead of a warning)- as they have no use in the AutoML Translation domain.

@shahar1 shahar1 deleted the delete-deprecated-automl-operators branch March 30, 2024 13:23
@shahar1 shahar1 mentioned this pull request Mar 30, 2024
Closed
2 tasks
@molcay
Copy link
Contributor

molcay commented Apr 2, 2024

Thank you for creating the revert PR @shahar1

Also, wrote to the PR #38633 and put a comment

This deprecation will be "strong" (i.e., raising an error instead of a warning)- as they have no use in the AutoML Translation domain.

Yes, indeed. I am already doing it. You can see my changes over this PR on another fork, I will be creating a community PR, ASAP (of course after the revert PR merged)

potiuk pushed a commit to shahar1/airflow that referenced this pull request Apr 2, 2024
@shahar1 @potiuk
Revert "Delete deprecated AutoML operators and deprecate AutoML hook …
50a8d37 
…and links (apache#38418)"

This reverts commit 4a4eee1
potiuk pushed a commit that referenced this pull request Apr 2, 2024
@shahar1
Revert "Delete deprecated AutoML operators and deprecate AutoML hook …
c443971 
…and links (#38418)" (#38633)

This reverts commit 4a4eee1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

Assignees

No one assigned

Labels

area:providers area:system-tests changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shahar1 @molcay @potiuk @ephraimbuddy