Add method to get metadata from GCS blob in GCSHook #38398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
dirrao
reviewed
Mar 23, 2024
amoghrajesh
reviewed
Mar 26, 2024
amoghrajesh
reviewed
Mar 28, 2024
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Changes look good to me! Running the workflow
eladkal
reviewed
Apr 3, 2024
Contributor
|
LGTM
|
shahar1
approved these changes
May 26, 2024
amoghrajesh
approved these changes
May 27, 2024
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
LGTM +1
@eladkal WDYT?
eladkal
approved these changes
May 27, 2024
Contributor
eladkal
left a comment
There was a problem hiding this comment.
LGTM
I just rebased the branch. Lets confirm CI is green
Member
Looks good. |
potiuk
approved these changes
May 27, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
* Adding get metadata to gcs hook * unit test * Spelling and rm fstrings * test for blob not found * fix pytest raises, add match regex
96 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* Adding get metadata to gcs hook * unit test * Spelling and rm fstrings * test for blob not found * fix pytest raises, add match regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCSHookdoesn't yet allow for the metadata attribute to be exposed, although it supports uploading of blobs and associating metadata with them.get_metadatamethod toGCSHookget_metadatafunction would retrieve metadata from blobs which already reside in a GCS bucket.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.