Work around typing issue in examples and providers #35494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Nov 7, 2023
Since this is just an example, we'll just ignore this and not worry too much about it.
The assignment syntax doesn't seem to be type-safe (although working at runtime), let's use a more semantic method.
Some of the parameters were too lax for Pandas and need to be tightened up.
This seems to be a definition issue between Numpy and Pandas? Not sure, but this works at runtime so let's not dig too deep. Simply annotating the variable as Any is enough to work around the problem.
This is just too much. Let's cast and not worry about it.
e6a8e64 to
281bc80
Compare
utkarsharma2
approved these changes
Nov 7, 2023
phanikumv
approved these changes
Nov 7, 2023
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
* Work around typing issue in workday examples Since this is just an example, we'll just ignore this and not worry too much about it. * Rewrite Pandas column-renaming The assignment syntax doesn't seem to be type-safe (although working at runtime), let's use a more semantic method. * Fix commin.sql arg type to Pandas Some of the parameters were too lax for Pandas and need to be tightened up. * More column rename fixes * Work around strict Numpy typing This seems to be a definition issue between Numpy and Pandas? Not sure, but this works at runtime so let's not dig too deep. Simply annotating the variable as Any is enough to work around the problem. * Work around complex Pandas typing This is just too much. Let's cast and not worry about it. * More parameters type fixes
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are typing issues surfaced by #35023. They are strictly unrelated to the PR but we should probably fix them.
CI errors that showed the errors: https://github.com/apache/airflow/actions/runs/6770061856/job/18399192125?pr=35023