Fix accessing a GKE cluster through the private endpoint in GKEStartPodOperator
#31391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
eladkal
reviewed
May 22, 2023
Comment on lines
-436
to
-443
| if use_internal_ip is not None: | ||
| warnings.warn( | ||
| f"You have set parameter use_internal_ip in class {self.__class__.__name__}. " | ||
| "In current implementation of the operator the parameter is not used and will " | ||
| "be deleted in future.", | ||
| AirflowProviderDeprecationWarning, | ||
| stacklevel=2, | ||
| ) |
Contributor
There was a problem hiding this comment.
Why was it deprecated to begin with?
Member
Author
There was a problem hiding this comment.
It was deprecated (technically removed with deprecation warning) in #29266.
It seems like they assumed that the new connection method can connect to any cluster through the public IP, without considering that some users disable access to their cluster from the public network, and that the current method always returns the public IP, even when public access is disabled.
potiuk
approved these changes
May 23, 2023
10 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31387
In this PR, I reuse the parameter
use_internal_ipwhich was removed in #29266 to allow the users to use the private endpoint to access the GKE cluster in the operatorGKEStartPodOperator.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.