Merging of the google ads vendored-in code. #30399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6033b2e to
ad0067e
Compare
Following google ads disabling v11 of their API, we are vendoring in google adds code. This is the first commit that just vendors in the original code of google-ads v. 20.0.0 It will be followed by a second PR where the code will be modified following the new package. Separating those two commits will help in case we have a need to migrate to another version of the library as then we will just revert this one and apply the second and resolve conflicts.
ad0067e to
ab78cb8
Compare
Member
Author
|
This one shoud be I think good to go. This is base for #switch to #30410 - it merely adds the unmodified google ads code so that we will be able to easily see where we made modifications so we should be good to go. |
eladkal
approved these changes
Apr 1, 2023
64 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 17, 2023
Now, when we switched to new dependencies for google provider, we can remove the google-ads vendored-in library that has been added to overcome the conflicts between google dependencies. This removes code added in apache#30399
potiuk
added a commit
that referenced
this pull request
May 18, 2023
Now, when we switched to new dependencies for google provider, we can remove the google-ads vendored-in library that has been added to overcome the conflicts between google dependencies. This removes code added in #30399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following google ads disabling v11 of their API, we are vendoring in google adds code. This is the first commit that just vendors in the original code of google-ads v. 20.0.0
It will be followed by a second PR where the code will be modified following the new package. Separating those two commits will help in case we have a need to migrate to another version of the library as then we will just revert this one and apply the second and resolve conflicts.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.