Improve creating Vault connection from the UI and add documentation for this conn #30057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 tasks
potiuk
approved these changes
Mar 15, 2023
Member
|
There is a conflict to resolve though. |
Member
Author
|
It should be fine now |
josh-fell
added a commit
to josh-fell/airflow
that referenced
this pull request
Mar 16, 2023
apache#30057 added a couple field validators in a new connection form for Hashicorp Vault. Behind the scenes, all connection form data is persisted upon submission. When creating a new connection that isn't Hashicrop Vault, these fields would not contain values that satisfy the validators of the fields. Making sure these offending fields are either optional or have a default value in the Hashicorp Vault conn form.
eladkal
pushed a commit
that referenced
this pull request
Mar 16, 2023
#30057 added a couple field validators in a new connection form for Hashicorp Vault. Behind the scenes, all connection form data is persisted upon submission. When creating a new connection that isn't Hashicrop Vault, these fields would not contain values that satisfy the validators of the fields. Making sure these offending fields are either optional or have a default value in the Hashicorp Vault conn form.
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #28790
This PR:
test_connectionto test Vault connection from UI