Move help message to the google auth code #29888
Conversation
|
Should fix failing "canary" main build. |
|
I wonder if we should just move all the underscore variables. |
Yeah. I was on the fence with this one, but I realized this is far more than our test's problem. Right now if anyone uses old google provider with the new google auth, it will miserably fail, so the risk of having the imports are far bigger than inlining all the imports there. cc: @eladkal - this one SHOULD be included in the new wave of providers, as soon we might be flooded with "google provider stopped working" and we will have no other workarounds for those users but "downgrade google-auth package to 2.16.1. When we release this in the provider, we will also be able to tell them "upgrade google provider". |
c0fe753 to
6c61d56
Compare
|
inlined all the constants now. |
Ok waiting for merge |
The "google-auth" 2.16.2 just released, removed the _HELP_MESSAGE that was imported by google provider auth util thus failing the imports in canary builds of ours attempting to upgrade to newver versions of released libraries. This PR inlines the original help message into our code to make it independent from google-auth package version used.
6c61d56 to
f2a9a1e
Compare
|
merged @eladkal |
|
Oups. I merged a bit too much. Will remove the code from _vendor that was accidentally added here |
The apache#29888 had merged accidentally some of the code that belonged to a different PR and the code should be removed.
|
#29895 removes the accidental additions |
The #29888 had merged accidentally some of the code that belonged to a different PR and the code should be removed.
The "google-auth" 2.16.2 just released, removed the _HELP_MESSAGE that was imported by google provider auth util thus failing the imports in canary builds of ours attempting to upgrade to newver versions of released libraries. This PR inlines the original help message into our code to make it independent from google-auth package version used. (cherry picked from commit 47ab0ca)
The "google-auth" 2.16.2 just released, removed the _HELP_MESSAGE that was imported by google provider auth util thus failing the imports in canary builds of ours attempting to upgrade to newver versions of released libraries. This PR inlines the original help message into our code to make it independent from google-auth package version used. (cherry picked from commit 47ab0ca)
The "google-auth" 2.16.2 just released, removed the _HELP_MESSAGE that was imported by google provider auth util thus failing the imports in canary builds of ours attempting to upgrade to newver versions of released libraries.
This PR inlines the original help message into our code to make it independent from google-auth package version used.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.