Skip to content

Restore trigger logging #29482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dstandish merged 2 commits into from
Feb 12, 2023
Merged

Restore trigger logging #29482

dstandish merged 2 commits into from
Feb 12, 2023

Conversation

@dstandish
Copy link
Contributor

@dstandish dstandish commented Feb 12, 2023 •
edited
Loading

Restores trigger logging PR #27758 which was reverted (#29472) due to CI problems.

See commit 5e8aed9 for the fix.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:CLI provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:logging area:providers area:Scheduler including HA (high availability) scheduler area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues provider:amazon AWS/Amazon - related issues provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Feb 12, 2023
@dstandish dstandish changed the title WIP - Restore trigger logging Restore trigger logging Feb 12, 2023
@dstandish dstandish marked this pull request as ready for review February 12, 2023 03:41
@dstandish dstandish merged commit f9e9d23 into apache:main Feb 12, 2023
@dstandish dstandish deleted the restore-trigger-logging branch February 12, 2023 05:14
@potiuk
Copy link
Member

potiuk commented Feb 12, 2023

Ah.. Nice catch @dstandish :)

@pierrejeambrun pierrejeambrun added this to the Airflow 2.6.0 milestone Feb 27, 2023
@pierrejeambrun pierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 27, 2023
@pierrejeambrun pierrejeambrun mentioned this pull request Mar 23, 2023
Merged
@potiuk potiuk mentioned this pull request May 23, 2023
Merged
potiuk added a commit to potiuk/airflow that referenced this pull request May 23, 2023
@potiuk
Give more time for trigger logs to propagate in tests
c117565 
After apache#29482 triggerer logs are not printed directly to the
stdout, but they are queued in memory and written by a separate
thread. This causes a slight flakiness in case of CI tests
for test_trigger_job - especially on MSSQL.

This simple workaround should give more time to the logs to
propgate during the test
potiuk added a commit that referenced this pull request May 23, 2023
@potiuk
Give more time for trigger logs to propagate in tests (#31470)
ba220b0 
After #29482 triggerer logs are not printed directly to the
stdout, but they are queued in memory and written by a separate
thread. This causes a slight flakiness in case of CI tests
for test_trigger_job - especially on MSSQL.

This simple workaround should give more time to the logs to
propgate during the test
@hussein-awala hussein-awala mentioned this pull request Jun 8, 2023
Closed
@thesuperzapper thesuperzapper mentioned this pull request May 9, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XD-DENG XD-DENG XD-DENG approved these changes

@eladkal eladkal Awaiting requested review from eladkal

@o-nikolas o-nikolas Awaiting requested review from o-nikolas

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton

@ashb ashb Awaiting requested review from ashb

@bbovenzi bbovenzi Awaiting requested review from bbovenzi

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

@potiuk potiuk Awaiting requested review from potiuk

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@kaxil kaxil Awaiting requested review from kaxil

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API area:CLI area:logging area:providers area:Scheduler including HA (high availability) scheduler area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:amazon AWS/Amazon - related issues provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues

Projects

None yet

Milestone

Airflow 2.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dstandish @potiuk @XD-DENG @pierrejeambrun