Filter celery stuck task query to exclude completed tasks#21335
Merged
ephraimbuddy merged 2 commits intoapache:mainfrom Feb 7, 2022
Merged
Filter celery stuck task query to exclude completed tasks#21335ephraimbuddy merged 2 commits intoapache:mainfrom
ephraimbuddy merged 2 commits intoapache:mainfrom
Conversation
dstandish
approved these changes
Feb 4, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
jedcunningham
approved these changes
Feb 4, 2022
ephraimbuddy
commented
Feb 4, 2022
Contributor
Author
There was a problem hiding this comment.
After mocking this query, because the update_all_task_states has the same query at BulkStateFetcher, it throws an error. I had to mock the update_all_task_states too
2cb2ac4 to
dd60224
Compare
potiuk
approved these changes
Feb 6, 2022
On testing apache#19769, it was reported that there was a spike in CPU usage apache#19769 (comment) Hopefully, this will fix it
dd60224 to
d0d4e6b
Compare
Contributor
Author
|
Thanks, @jedcunningham for spotting this! |
jedcunningham
pushed a commit
that referenced
this pull request
Feb 8, 2022
On testing #19769, it was reported that there was a spike in CPU usage #19769 (comment) Hopefully, this will fix it (cherry picked from commit a49224f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On testing #19769, it was reported that there was a spike in CPU usage #19769 (comment)
Hopefully, this will fix it
cc: @jedcunningham
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.