Update md5 information about image after waiting #21000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "wait_for_image" was called, the information that the image was built (including the information about md5 hashes of important files) had not been stored locally. It was only stored when image was pulled by "prepare_image". Constraints job uses wait for image, because it runs in parallel for all python versions. With recent changes, the flag that image had never been built, automatically generates image build - unnecessarily, because the image is already pulled by "wait_for_image". It made almost no difference for "regular builds" because the image is rebuilt from cache (which is now very quick) but in case of PRs that change setup.py it caused image rebuild. Additionally if this iamge has conflicting requirement, it would cause build failure. The change simply registers the fact that image is "ok" so that no attempt to rebuild image happens when constraints are generated.
Member
Author
|
Hey @ashb - this one line missing in recent "buildx" caused the constraint failure. |
ashb
approved these changes
Jan 21, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
When "wait_for_image" was called, the information that the image was built (including the information about md5 hashes of important files) had not been stored locally. It was only stored when image was pulled by "prepare_image". Constraints job uses wait for image, because it runs in parallel for all python versions. With recent changes, the flag that image had never been built, automatically generates image build - unnecessarily, because the image is already pulled by "wait_for_image". It made almost no difference for "regular builds" because the image is rebuilt from cache (which is now very quick) but in case of PRs that change setup.py it caused image rebuild. Additionally if this iamge has conflicting requirement, it would cause build failure. The change simply registers the fact that image is "ok" so that no attempt to rebuild image happens when constraints are generated. (cherry picked from commit e5da9bf)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
When "wait_for_image" was called, the information that the image was built (including the information about md5 hashes of important files) had not been stored locally. It was only stored when image was pulled by "prepare_image". Constraints job uses wait for image, because it runs in parallel for all python versions. With recent changes, the flag that image had never been built, automatically generates image build - unnecessarily, because the image is already pulled by "wait_for_image". It made almost no difference for "regular builds" because the image is rebuilt from cache (which is now very quick) but in case of PRs that change setup.py it caused image rebuild. Additionally if this iamge has conflicting requirement, it would cause build failure. The change simply registers the fact that image is "ok" so that no attempt to rebuild image happens when constraints are generated. (cherry picked from commit e5da9bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "wait_for_image" was called, the information that the image
was built (including the information about md5 hashes of important
files) had not been stored locally. It was only stored when
image was pulled by "prepare_image". Constraints job uses
wait for image, because it runs in parallel for all python versions.
With recent changes, the flag that image had never been built,
automatically generates image build - unnecessarily, because the
image is already pulled by "wait_for_image".
It made almost no difference for "regular builds" because the image
is rebuilt from cache (which is now very quick) but in case of
PRs that change setup.py it caused image rebuild. Additionally if
this iamge has conflicting requirement, it would cause build failure.
The change simply registers the fact that image is "ok" so that
no attempt to rebuild image happens when constraints are generated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.