Add a short chapter focusing on adapting secret format for connections #19859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of discussion in apache#19857, I propose to add this short chapter to respond to anticipated need of organisations to keep the connections in format that is not Airflow-exclusive. I think it would be good to explicitly state what is the Airflow approach in this case (i.e. either using existing capabilities of secret backends when they are there - for example in AWS - or rolling your own backend, possibly by extending the community provided ones if the flexibility is not implemented by the community provided backend.
f154493 to
b4ef406
Compare
dstandish
approved these changes
Nov 29, 2021
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
mik-laj
approved these changes
Nov 29, 2021
dstandish
approved these changes
Nov 29, 2021
dillonjohnson
pushed a commit
to dillonjohnson/airflow
that referenced
this pull request
Dec 1, 2021
apache#19859) * Add a short chapter focusing on adapting secret format for connections As a result of discussion in apache#19857, I propose to add this short chapter to respond to anticipated need of organisations to keep the connections in format that is not Airflow-exclusive. I think it would be good to explicitly state what is the Airflow approach in this case (i.e. either using existing capabilities of secret backends when they are there - for example in AWS - or rolling your own backend, possibly by extending the community provided ones if the flexibility is not implemented by the community provided backend.
jedcunningham
pushed a commit
that referenced
this pull request
Dec 7, 2021
#19859) * Add a short chapter focusing on adapting secret format for connections As a result of discussion in #19857, I propose to add this short chapter to respond to anticipated need of organisations to keep the connections in format that is not Airflow-exclusive. I think it would be good to explicitly state what is the Airflow approach in this case (i.e. either using existing capabilities of secret backends when they are there - for example in AWS - or rolling your own backend, possibly by extending the community provided ones if the flexibility is not implemented by the community provided backend. (cherry picked from commit 399ae0b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of discussion in #19857, I propose to add this short
chapter to respond to anticipated need of organisations to keep the
connections in format that is not Airflow-exclusive. I think it would
be good to explicitly state what is the Airflow approach in this case
(i.e. either using existing capabilities of secret backends when
they are there - for example in AWS - or rolling your own backend,
possibly by extending the community provided ones if the flexibility
is not implemented by the community provided backend.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.