Move bucket_name validation out of __init__ in Google Marketing Platform operators
#19383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bucket_name in Google Marketing Platform operatorsbucket_name validation out of __init__ in Google Marketing Platform operators
d8bbadb to
1fd8fe8
Compare
uranusjr
approved these changes
Nov 17, 2021
Member
|
LGTM, retrying tests. |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
1fd8fe8 to
8fce460
Compare
potiuk
approved these changes
Nov 28, 2021
Member
|
MSSql errors were unrelated .. |
44 tasks
dillonjohnson
pushed a commit
to dillonjohnson/airflow
that referenced
this pull request
Dec 1, 2021
…latform operators (apache#19383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GoogleCampaignManagerDownloadReportOperator,GoogleDisplayVideo360DownloadReportOperator, andGoogleSearchAdsDownloadReportOperatorperform a string validation on thebucket_namearg in their constructor. This arg is a templated field which means the input could be anXComArg. Unfortunately, this string validation fails withAttributeError: 'XComArg' object has no attribute 'startswith'when the input arg forbucket_nameis anXComArg.This PR ensures that, if desired, the
bucket_namearg can be successfully passed to these operators as anXComArg.Also included in this PR is some DRY refactoring of the operator unit tests to use some global variables across tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.