-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add Google Cloud Workflows Operators #13366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
tolkjen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing the operators so quickly!
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
5e695fe to
6cf2971
Compare
|
@TobKed would you mind taking a look? |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
airflow/providers/google/cloud/example_dags/example_workflows.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/example_dags/example_workflows.py
Outdated
Show resolved
Hide resolved
TobKed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Good job!. I just left some minor comments
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
airflow/providers/google/cloud/example_dags/example_workflows.py
Outdated
Show resolved
Hide resolved
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
@mik-laj is the docs build failure related? I see many errors but those seems to affect all packages not only google |
mongo vs mongodb Can you check that all vendor names are consistently used? |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
I found a problem. https://api.mongodb.com/python/current this links doesn't works. |
|
https://pymongo.readthedocs.io/en/latest/ this links works now. |
fixup! Add system test, example and sensor
b98cc74 to
575a8cd
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
fixup! Rename operators and add docs Apply suggestions from code review Co-authored-by: Tobiasz Kędzierski <tobiasz.kedzierski@polidea.com> Update airflow/providers/google/cloud/hooks/workflows.py Co-authored-by: Tobiasz Kędzierski <tobiasz.kedzierski@polidea.com> fixup! fixup! Rename operators and add docs fixup! fixup! fixup! Rename operators and add docs fixup! fixup! fixup! fixup! Rename operators and add docs fixup! fixup! fixup! fixup! fixup! Rename operators and add docs fixup! fixup! fixup! fixup! fixup! fixup! Rename operators and add docs Update airflow/providers/google/cloud/example_dags/example_workflows.py Co-authored-by: Tobiasz Kędzierski <tobiasz.kedzierski@polidea.com>
575a8cd to
f12cbcc
Compare
Add Google Cloud Workflows Operators, system test, example and sensor Co-authored-by: Tobiasz Kędzierski <tobiasz.kedzierski@polidea.com> (cherry picked from commit 6d6588f)
Add Google Cloud Workflows Operators, system test, example and sensor Co-authored-by: Tobiasz Kędzierski <tobiasz.kedzierski@polidea.com> (cherry picked from commit 6d6588f)
Add Google Cloud Workflows Operators, system test, example and sensor Co-authored-by: Tobiasz Kędzierski <tobiasz.kedzierski@polidea.com> (cherry picked from commit 6d6588f)
Todo:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.