Skip to content

Conversation

@ecerulm
Copy link
Contributor

@ecerulm ecerulm commented Dec 14, 2020

Closes #12613

@boring-cyborg boring-cyborg bot added area:dev-tools provider:Apache provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Dec 14, 2020
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@ecerulm
Copy link
Contributor Author

ecerulm commented Dec 15, 2020

@mik-laj just mentioning you since I can't "request a review" from you.

You can invoke the script as:

python scripts/tools/generate-integrations-json.py >../airflow-site/landing-pages/site/data/integrations.json

and the output look like

[
    {
        "name": "Discord",
        "url": "/docs/apache-airflow-providers-discord/stable/index.html"
    },
    {
        "name": "Amazon Athena",
        "url": "/docs/apache-airflow-providers-amazon/stable/index.html",
        "logo": "/integration-logos/aws/Amazon-Athena_light-bg@4x.png"
    },
    {
        "name": "Amazon CloudFormation",
        "url": "/docs/apache-airflow-providers-amazon/stable/index.html"
    },
    {
        "name": "Amazon CloudWatch Logs",
        "url": "/docs/apache-airflow-providers-amazon/stable/index.html",
        "logo": "/integration-logos/aws/Amazon-CloudWatch_light-bg@4x.png"
    },
...
]

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@ecerulm ecerulm force-pushed the airflow-12613 branch 3 times, most recently from 003f478 to 4fc7430 Compare December 15, 2020 10:04
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@ecerulm ecerulm force-pushed the airflow-12613 branch 3 times, most recently from e2a588f to b014d0a Compare December 15, 2020 13:27
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we write directly to the airflow-site location. landing-pages/site/data/integrations.json is a symbolic link to this one.

@ecerulm ecerulm force-pushed the airflow-12613 branch 2 times, most recently from 58b35a8 to c1af290 Compare December 15, 2020 14:40
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 15, 2020
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@mik-laj
Copy link
Member

mik-laj commented Dec 15, 2020

Fantastic! Can you now prepare a new PR with an update to airflow-site (target branch: airflow-2-0-docs)?

@mik-laj mik-laj merged commit 5090fb0 into apache:master Dec 15, 2020
@ecerulm
Copy link
Contributor Author

ecerulm commented Dec 16, 2020

Sure, you mean just updating integrations.json and the integration-logos right?

@mik-laj
Copy link
Member

mik-laj commented Dec 16, 2020

@ecerulm Yes. We added a lot of new integration, so we need to regenerate integration.json.

potiuk pushed a commit that referenced this pull request Mar 3, 2021
@ecerulm ecerulm deleted the airflow-12613 branch June 16, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration list synchronization with airflow-site

2 participants