fix(deps): update module github.com/stretchr/testify to v1.11.1 (main) by renovate[bot] · Pull Request #7448 · antrea-io/antrea

renovate · 2025-09-17T02:10:04Z

Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.

This PR contains the following updates:

Package	Change	Age	Confidence
github.com/stretchr/testify	`v1.10.0` -> `v1.11.1`

Release Notes

stretchr/testify (github.com/stretchr/testify)

`v1.11.1`

Compare Source

This release fixes #1785 introduced in v1.11.0 where expected argument values implementing the stringer interface (String() string) with a method which mutates their value, when passed to mock.Mock.On (m.On("Method", <expected>).Return()) or actual argument values passed to mock.Mock.Called may no longer match one another where they previously did match. The behaviour prior to v1.11.0 where the stringer is always called is restored. Future testify releases may not call the stringer method at all in this case.

What's Changed

Backport #1786 to release/1.11: mock: revert to pre-v1.11.0 argument matching behavior for mutating stringers by @brackendawson in #1788

Full Changelog: stretchr/testify@v1.11.0...v1.11.1

`v1.11.0`

Compare Source

What's Changed

Functional Changes

v1.11.0 Includes a number of performance improvements.

Call stack perf change for CallerInfo by @mikeauclair in #1614
Lazily render mock diff output on successful match by @mikeauclair in #1615
assert: check early in Eventually, EventuallyWithT, and Never by @cszczepaniak in #1427
assert: add IsNotType by @bartventer in #1730
assert.JSONEq: shortcut if same strings by @dolmen in #1754
assert.YAMLEq: shortcut if same strings by @dolmen in #1755
assert: faster and simpler isEmpty using reflect.Value.IsZero by @dolmen in #1761
suite: faster methods filtering (internal refactor) by @dolmen in #1758

Fixes

assert.ErrorAs: log target type by @craig65535 in #1345
Fix failure message formatting for Positive and Negative asserts in #1062
Improve ErrorIs message when error is nil but an error was expected by @tsioftas in #1681
fix Subset/NotSubset when calling with mixed input types by @siliconbrain in #1729
Improve ErrorAs failure message when error is nil by @ccoVeille in #1734
mock.AssertNumberOfCalls: improve error msg by @3scalation in #1743

Documentation, Build & CI

docs: Fix typo in README by @alexandear in #1688
Replace deprecated io/ioutil with io and os by @alexandear in #1684
Document consequences of calling t.FailNow() by @greg0ire in #1710
chore: update docs for Unset #1621 by @techfg in #1709
README: apply gofmt to examples by @alexandear in #1687
refactor: use %q and %T to simplify fmt.Sprintf by @alexandear in #1674
Propose Christophe Colombier (ccoVeille) as approver by @brackendawson in #1716
Update documentation for the Error function in assert or require package by @architagr in #1675
assert: remove deprecated build constraints by @alexandear in #1671
assert: apply gofumpt to internal test suite by @ccoVeille in #1739
CI: fix shebang in .ci.*.sh scripts by @dolmen in #1746
assert,require: enable parallel testing on (almost) all top tests by @dolmen in #1747
suite.Passed: add one more status test report by @Ararsa-Derese in #1706
Add Helper() method in internal mocks and assert.CollectT by @dolmen in #1423
assert.Same/NotSame: improve usage of Sprintf by @ccoVeille in #1742
mock: enable parallel testing on internal testsuite by @dolmen in #1756
suite: cleanup use of 'testing' internals at runtime by @dolmen in #1751
assert: check test failure message for Empty and NotEmpty by @ccoVeille in #1745
deps: fix dependency cycle with objx (again) by @dolmen in #1567
assert.Empty: comprehensive doc of "Empty"-ness rules by @dolmen in #1753
doc: improve godoc of top level 'testify' package by @dolmen in #1760
assert.ErrorAs: simplify retrieving the type name by @ccoVeille in #1740
assert.EqualValues: improve test coverage to 100% by @dolmen in #1763
suite.Run: simplify running of Setup/TeardownSuite by @renzoarreaza in #1769
assert.CallerInfo: micro optimization by using LastIndexByte by @dolmen in #1767
assert.CallerInfo: micro cleanup by @dolmen in #1768
assert: refactor TestFileExists and TestDirExists tests to enable parallel testing by @dolmen in #1766
suite.Run: refactor handling of stats for improved readability by @dolmen in #1764
tests: improve captureTestingT helper by @ccoVeille in #1741
build(deps): bump actions/checkout from 4 to 5 by @dependabot[bot] in #1778

New Contributors

@greg0ire made their first contribution in #1710
@techfg made their first contribution in #1709
@mikeauclair made their first contribution in #1614
@cszczepaniak made their first contribution in #1427
@architagr made their first contribution in #1675
@tsioftas made their first contribution in #1681
@siliconbrain made their first contribution in #1729
@bartventer made their first contribution in #1730
@Ararsa-Derese made their first contribution in #1706
@renzoarreaza made their first contribution in #1769
@3scalation made their first contribution in #1743

Full Changelog: stretchr/testify@v1.10.0...v1.11.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

antoninbas · 2025-09-22T17:47:17Z

/test-all

antoninbas · 2025-09-23T00:11:53Z

Some test failures that I need to resolve manually. I had the same issue with vmware/go-ipfix.

The tests were not correct to begin with, and a change in the `assert.Eventually` implementation exposed the bug: stretchr/testify#1427 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>

renovate · 2025-09-23T01:22:12Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

antoninbas · 2025-09-23T01:50:32Z

@luolanzone some manual fixes were required as 2 unit tests started failing after the dependency upgrade (because of this change: stretchr/testify#1427). PTAL.

luolanzone · 2025-09-23T02:04:29Z

/test-all

This is a follow-up to antrea-io#7448. The change in behavor of assert.Eventually has caused to the unit test to become flaky. This change improves how the result of egress selection is validated, and resolves the flakiness issue. It is expected that the test function can be greatly improved when we upgrade to Go 1.25 and we can start using the new testing/synctest package. Upgrading to Go 1.25 is not immediately possible because of some dependency issues. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>

The test had an invalid usage of assert.EventuallyWithT: the assertions included in the condition function applied to the outer *testing.T instead of to the condition function parameter. After antrea-io#7448, the test started failing due to the change in the implementation of assert.EventuallyWithT. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>

The test had an invalid usage of assert.EventuallyWithT: the assertions included in the condition function applied to the outer *testing.T instead of to the condition function parameter. After #7448, the test started failing due to the change in the implementation of assert.EventuallyWithT. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>

This is a follow-up to #7448. The change in behavor of assert.Eventually has caused to the unit test to become flaky. This change improves how the result of egress selection is validated, and resolves the flakiness issue. It is expected that the test function can be greatly improved when we upgrade to Go 1.25 and we can start using the new testing/synctest package. Upgrading to Go 1.25 is not immediately possible because of some dependency issues. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>

antrea-io#7448) * fix(deps): update module github.com/stretchr/testify to v1.11.1 Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix race conditions in unit tests The tests were not correct to begin with, and a change in the `assert.Eventually` implementation exposed the bug: stretchr/testify#1427 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Antonin Bas <antonin.bas@broadcom.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Antonin Bas <antonin.bas@broadcom.com>

…7469) The test had an invalid usage of assert.EventuallyWithT: the assertions included in the condition function applied to the outer *testing.T instead of to the condition function parameter. After antrea-io#7448, the test started failing due to the change in the implementation of assert.EventuallyWithT. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>

…tretchr/testify to v1.11.1 #7433 to update module github.com/spf13/pflag to v1.0.10 #7469 Fix typo in TestPreventDefunctRuleReuse (#7886) * fix(deps): update module github.com/stretchr/testify to v1.11.1 (main) (#7448) * fix(deps): update module github.com/stretchr/testify to v1.11.1 Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix race conditions in unit tests The tests were not correct to begin with, and a change in the `assert.Eventually` implementation exposed the bug: stretchr/testify#1427 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Antonin Bas <antonin.bas@broadcom.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Antonin Bas <antonin.bas@broadcom.com> * fix(deps): update module github.com/spf13/pflag to v1.0.10 (#7433) Signed-off-by: Lan Luo <lan.luo@broadcom.com> * [Flaky unit test] Fix typo in TestPreventDefunctRuleReuse (#7469) The test had an invalid usage of assert.EventuallyWithT: the assertions included in the condition function applied to the outer *testing.T instead of to the condition function parameter. After #7448, the test started failing due to the change in the implementation of assert.EventuallyWithT. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Antonin Bas <antonin.bas@broadcom.com> Signed-off-by: Lan Luo <lan.luo@broadcom.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Antonin Bas <antonin.bas@broadcom.com>

renovate Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 17, 2025

renovate Bot changed the title ~~fix(deps): update module github.com/stretchr/testify to v1.11.1 (main)~~ Update module github.com/stretchr/testify to v1.11.1 (main) Sep 17, 2025

renovate Bot changed the title ~~Update module github.com/stretchr/testify to v1.11.1 (main)~~ fix(deps): update module github.com/stretchr/testify to v1.11.1 (main) Sep 17, 2025

fix(deps): update module github.com/stretchr/testify to v1.11.1

64994d5

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate Bot force-pushed the renovate/main-github.com-stretchr-testify-1.x branch from 3a3b007 to 64994d5 Compare September 17, 2025 20:44

antoninbas self-assigned this Sep 23, 2025

Fix race conditions in unit tests

0e029e6

The tests were not correct to begin with, and a change in the `assert.Eventually` implementation exposed the bug: stretchr/testify#1427 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>

antoninbas requested a review from luolanzone September 23, 2025 01:50

luolanzone approved these changes Sep 23, 2025

View reviewed changes

antoninbas merged commit 03f9e58 into main Sep 23, 2025
57 of 61 checks passed

antoninbas deleted the renovate/main-github.com-stretchr-testify-1.x branch September 23, 2025 17:39

antoninbas mentioned this pull request Sep 23, 2025

[Flaky unit test] Fix TestCluster_RunClusterEvents #7467

Merged

antoninbas mentioned this pull request Sep 24, 2025

[Flaky unit test] Fix typo in TestPreventDefunctRuleReuse #7469

Merged

luolanzone mentioned this pull request Mar 24, 2026

Automated cherry pick of #7448: fix(deps): update module github.com/stretchr/testify to v1.11.1 #7433 to update module github.com/spf13/pflag to v1.0.10 #7469 Fix typo in TestPreventDefunctRuleReuse #7886

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update module github.com/stretchr/testify to v1.11.1 (main)#7448

fix(deps): update module github.com/stretchr/testify to v1.11.1 (main)#7448
antoninbas merged 2 commits intomainfrom
renovate/main-github.com-stretchr-testify-1.x

renovate Bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

antoninbas commented Sep 22, 2025

Uh oh!

antoninbas commented Sep 23, 2025

Uh oh!

renovate Bot commented Sep 23, 2025

Uh oh!

antoninbas commented Sep 23, 2025

Uh oh!

luolanzone commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

renovate Bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

v1.11.1

What's Changed

v1.11.0

What's Changed

Functional Changes

Fixes

Documentation, Build & CI

New Contributors

Configuration

Uh oh!

antoninbas commented Sep 22, 2025

Uh oh!

antoninbas commented Sep 23, 2025

Uh oh!

renovate Bot commented Sep 23, 2025

Edited/Blocked Notification

Uh oh!

antoninbas commented Sep 23, 2025

Uh oh!

luolanzone commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

renovate Bot commented Sep 17, 2025 •

edited

Loading

`v1.11.1`

`v1.11.0`