refactor: Move Provider tests to forge_infra with sequential execution#414
Merged
tusharmath merged 2 commits intomainfrom Feb 28, 2025
Merged
refactor: Move Provider tests to forge_infra with sequential execution#414tusharmath merged 2 commits intomainfrom
tusharmath merged 2 commits intomainfrom
Conversation
…ecution This commit moves all provider-related tests from forge_domain/src/provider.rs to forge_infra/src/env.rs which is a more appropriate location for environment variable testing. Also adds the serial_test crate to ensure tests run sequentially since they modify shared environment variables. Changes: - Add serial_test as a dev dependency to forge_infra - Move all provider tests to env.rs - Add #[serial] attribute to tests to prevent race conditions - Remove tests from provider.rs
laststylebender14
pushed a commit
to dekkku/forge
that referenced
this pull request
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Move Provider tests to forge_infra with sequential execution
Description
This PR moves provider-related tests from
forge_domain/src/provider.rstoforge_infra/src/env.rsand configures them to run sequentially, which is more appropriate for environment variable testing.Changes
serial_testas a dev dependency toforge_infraenv.rs#[serial]attribute to tests to prevent race conditions when modifying environment variablesprovider.rsMotivation
The tests were manipulating environment variables but were located in the domain crate. Since
forge_infrais responsible for environment interactions, this is a more appropriate location for these tests. Additionally, these tests need to run sequentially to avoid race conditions since they modify shared environment state.Testing