Skip to content

fix: provider flaky tests#411

Closed
dekkku wants to merge 3 commits intoantinomyhq:mainfrom
dekkku:fix/flaky-tests
Closed

fix: provider flaky tests#411
dekkku wants to merge 3 commits intoantinomyhq:mainfrom
dekkku:fix/flaky-tests

Conversation

@dekkku
Copy link
Copy Markdown

@dekkku dekkku commented Feb 27, 2025

The tests were failing randomly because multiple tests were changing environment variables at the same time.

@tusharmath
Copy link
Copy Markdown
Collaborator

Tests aren't failing in on main.

@dekkku
Copy link
Copy Markdown
Author

dekkku commented Feb 27, 2025

Weirdly, for me tests are failing randomly because the environment vars are shared and test's run in parallel.
something similar is happening in api_spec.rs file. ref: 5bb803e

@tusharmath
Copy link
Copy Markdown
Collaborator

My recommendation here is:

  1. Move Provider::from_env to forge_infra::env
  2. Drop the tests for reading from env for now

@tusharmath
Copy link
Copy Markdown
Collaborator

This has been fixed in #414

Thanks @dekkku !

@tusharmath tusharmath closed this Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants