fix(Progress): prevent animation overflow when status is set to active#56972
fix(Progress): prevent animation overflow when status is set to active#56972thinkasany merged 2 commits intoant-design:masterfrom
Conversation
|
|
👁 Visual Regression Report for PR #56972 Failed ❌
Important There are 3 diffs found in this PR: 🔄
|
Summary of ChangesHello @aibayanyu20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a visual defect in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix an animation overflow issue in the Progress component by adding overflow: hidden. While the fix is effective for the active state animation, applying overflow: hidden unconditionally to the rail introduces a regression. Specifically, it can cause clipping of inner text content when the text is long, as the progress track is designed to expand to fit its content. My review includes a suggestion to apply overflow: hidden conditionally only when the progress status is 'active', which resolves the animation issue without causing the content clipping regression.
More templates
commit: |
Bundle ReportChanges will decrease total bundle size by 6.1MB (-64.47%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
Files in
|
📝 WalkthroughSummary by CodeRabbit发布说明
Walkthrough在 Progress 组件的进度条轨道样式中新增 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #56972 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 807 807
Lines 15116 15047 -69
Branches 3991 3962 -29
=========================================
- Hits 15116 15047 -69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|











中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
close #56967
💡 Background and Solution
Fix animation overflow when
Progressstatus is set to"active"by addingoverflow: hiddento the rail class.📝 Change Log
status="active"时动画溢出的问题。