feat(Upload): upload support to setting upload button class names style#56578
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
👁 Visual Regression Report for PR #56578 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 16 diffs found in this PR: 🔄
|
|
|
Summary of ChangesHello @QdabuliuQ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully adds support for classNames.uploadButton and styles.uploadButton to the Upload component, allowing for better customization of the upload button container. The implementation is clean, follows existing patterns in the codebase, and is well-tested with new unit tests and demo updates. The changes are correct and address the feature request effectively. I have no further suggestions for improvement.
More templates
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #56578 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 807 807
Lines 14946 14946
Branches 3943 3943
=========================================
Hits 14946 14946 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 536 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
components/upload/demo/_semantic.tsx
Outdated
| root: 'Root container element with layout styles, disabled text color, user-select control, cursor styles and other basic styles', | ||
| list: 'File list container with layout arrangement, transition animations, spacing control and other styles', | ||
| item: 'File item element with padding, background color, border styles, hover effects, status colors, transition animations and other styles', | ||
| uploadButton: |
There was a problem hiding this comment.
这个描述不对
应该 是 upload Button root 类似
@zombieJ 豆酱这个语义化名称 得定一下吧 , 这个感觉怪怪的
Co-authored-by: 𝑾𝒖𝒙𝒉 <wxh16144@qq.com> Signed-off-by: thinkasany <480968828@qq.com>
…le (ant-design#56578) * feat: add uploadButton support to Upload classNames and styles * fix: rename uploadButton style key to trigger in Upload * feat: support custom trigger class and style in Upload * Update components/upload/demo/_semantic.tsx Co-authored-by: 𝑾𝒖𝒙𝒉 <wxh16144@qq.com> Signed-off-by: thinkasany <480968828@qq.com> * chore: updare upload snapshot file --------- Signed-off-by: thinkasany <480968828@qq.com> Co-authored-by: 遇见同学 <1875694521@qq.com> Co-authored-by: thinkasany <480968828@qq.com> Co-authored-by: 𝑾𝒖𝒙𝒉 <wxh16144@qq.com>
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
issues: 56571
💡 Background and Solution
Upload component lacks semantic customization support for the upload button container.
Add uploadButton to classNames and styles props for controlling the upload button container (ant-upload-select) styles.
📝 Change Log