feat(Tooltip): add maxWidth token#56540
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
👁 Visual Regression Report for PR #56540 Failed ❌
Important There are 2 diffs found in this PR: 🔄
|
Summary of ChangesHello @guoyunhe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Tooltip component by introducing a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new maxWidth token for the Tooltip component, allowing for easier customization of its maximum width. The implementation is clean and follows the project's conventions. However, the change lacks automated tests to verify the new token's functionality. I've added a comment with a suggestion for a test case to ensure the feature is robust and to prevent regressions.
More templates
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #56540 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 807 807
Lines 14867 14867
Branches 3935 3935
=========================================
Hits 14867 14867 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 8.13MB (210.52%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
Files in
|
afc163
left a comment
There was a problem hiding this comment.
默认值可以改成 fit-content 了
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/fit-content
afc163
left a comment
There was a problem hiding this comment.
默认值可以改成 fit-content 了
developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/fit-content
@afc163 感觉这样就 breaking change 了,不敢搞 |
|
可以搞,250 是个拍脑袋的数字,fit-content 应该更合理。 |
@afc163 试了一下用 fit-content 某些 demo 会出现气泡和箭头分离的情况,可能是 JS 的定位算法没考虑到动态宽度?
|
|
估计是,那先不改。 |








中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log