fix: Select input cursor unexpectedly appearing in non search mode#56067
fix: Select input cursor unexpectedly appearing in non search mode#56067
Conversation
|
|
Deploying ant-design-next with
|
| Latest commit: |
8a21905
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bbd976eb.ant-design-next.pages.dev |
| Branch Preview URL: | https://fix-add-transparent-caret-co.ant-design-next.pages.dev |
👁 Visual Regression Report for PR #56067 Passed ✅
🎊 Congrats! No visual-regression diff found.
|
Summary of ChangesHello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but noticeable visual bug in the Select component. Previously, a text caret would appear in the input field even when it was in a read-only state and not actively being used for search, leading to a confusing user experience. The change ensures that the caret is hidden in these specific scenarios, providing a cleaner and more intuitive interface for users interacting with the Select component. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. Walkthrough在 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (8)**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
components/**/style/*.ts📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
components/**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx,md}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx,css}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx,js}📄 CodeRabbit inference engine (AGENTS.md)
Files:
components/**/style/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
components/**/style/**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request addresses a visual bug in the Select component where a text cursor (caret) was displayed in the input field even when it was not searchable. The fix involves setting caretColor: 'transparent' for readonly inputs within the select component. This is a clean and effective solution that correctly hides the caret, improving the user experience by removing a misleading visual cue. The change is minimal, targeted, and I see no issues with it. Well done.
Deploying ant-design with
|
| Latest commit: |
8a21905
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2a46b2e.ant-design.pages.dev |
| Branch Preview URL: | https://fix-add-transparent-caret-co.ant-design.pages.dev |
size-limit report 📦
|
More templates
commit: |
More templates
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #56067 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 803 803
Lines 14831 14831
Branches 3916 3916
=========================================
Hits 14831 14831 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 50 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|


中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
close #55856
💡 Background and Solution
📝 Change Log